Review main Merged

17881[BUGFIX] LocalDriver: Recursive file listing is broken

Andreas Wolf CR +2 V +2 Hard +255 −24 updated 07/22/13, 10:30

Commit message

The recursive file listing, introduced as part of the public API in
the fix for #43249, is currently broken.

One problem is that the file information retrieval is incomplete: The
filename of files in subfolders also contains the path to this file from
the current folder, while the identifier is missing that information.
The identifier is thus wrong and the filename contains too much
information (more than the filename).

Additionally, the method getDirectoryItemList() returns the file list
with the filenames as key, which will fail when a file name exists twice
in different folders. Therefore, this patch changes the keys to numeric
values when a recursive folder list is requested.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 7

Review log 34

Show 9 earlier messages
  1. Andreas Wolf uploaded patch set 2 05/27/13, 17:19

  2. Christian Kuhn commented on patch set 1 05/27/13, 17:19

    no test?
  3. Christian Kuhn commented on patch set 1 05/27/13, 17:19

    Do not submit -2 until there are unit tests for this, the related issue also had them, so if its broken in there, some test should fail, or we should at least get some regression test now.
  4. Andreas Wolf uploaded patch set 4 05/27/13, 17:19

  5. Andreas Wolf uploaded patch set 5 05/27/13, 17:19

  6. Andreas Wolf commented on patch set 5 05/27/13, 17:19

    Small change to make Mr. Jenkins happy again.
  7. Stefan Neufeind commented on patch set 5 05/27/13, 17:19

    Fails Tests fail here. Looking into it.

    LocalDriver.php:322

    that class does not exist, thus entries are not sorted! Did you maybe miss to git-add it?
  8. Andreas Wolf uploaded patch set 7 05/27/13, 17:19

  9. Stefan Neufeind commented on patch set 6 V 0 05/27/13, 17:19

    Result was correct. Files were just returned in a different order than in the testcase. Updated testcase.
  1. Stefan Neufeind uploaded patch set 6 05/27/13, 17:19

  2. Stefan Neufeind commented on patch set 6 1 comment 05/27/13, 17:19

    No score; I would prefer that you didn't submit this missing a referenced helper-class @Andreas: Could it be you still have that file around on your side?
  3. Stefan Neufeind uploaded patch set 8 05/27/13, 17:19

  4. Stefan Neufeind commented on patch set 9 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Made Jenkins happy (patchset #9) and adjusted testcase because returned data is now correctly sorted (patchset #10).
  5. Stefan Neufeind commented on patch set 9 05/27/13, 17:19

    ping
  6. Stefan Neufeind uploaded patch set 9 05/27/13, 17:19

  7. Christian Kuhn commented on patch set 3 05/27/13, 17:19

    I would prefer that you didn't submit this
  8. Christian Kuhn uploaded patch set 3 05/27/13, 17:19

  9. Steffen Ritter commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve
  10. Steffen Ritter commented on patch set 5 05/27/13, 17:19

    Looks Good at First sight...
  11. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7268/ : FAILURE
  12. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7416/ : FAILURE
  13. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  14. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7425/ : FAILURE
  15. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  16. Mr. Jenkins commented on patch set 6 05/27/13, 17:19

  17. Mr. Jenkins commented on patch set 7 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8359/ : FAILURE
  18. Mr. Jenkins commented on patch set 8 05/27/13, 17:19

  19. Mr. Jenkins commented on patch set 9 05/27/13, 17:19

  20. Stefan Neufeind commented on patch set 9 06/29/13, 12:48

    and 6.2
  21. Steffen Ritter uploaded patch set 10 07/04/13, 19:17

  22. Steffen Ritter voted on patch set 10 V +2 CR +2 07/04/13, 19:18

  23. Steffen Ritter merged patch set 11 07/04/13, 19:18

  24. Mr. Jenkins commented on patch set 10 07/04/13, 19:18

  25. Martin Borer commented on patch set 11 07/22/13, 10:30

    Is it possible that this change has broken the Filelist Module on Windows? see ticket: #49794 There is always a wrong formated basePath information in front of the folder, for example: /\/user_upload/ instead of /user_upload/