Review main Abandoned

17918[BUGFIX] Flexform "required" on input fields applies to last field only

Christian Weiske CR 0 V 0 Easy +4 −7 updated 04/21/15, 12:25

Commit message

When a flexform has several input fields with "required" eval option,
only the last one is validated. The requirement for all but the last one
is ignored.

This patch fixes the bug by using the flexform field name instead of
the database field name as array key.
This does still work for "normal" fields, since both values are
populated (tested with "htmlArea RTE abbreviation").

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 17

  1. Christian Weiske uploaded patch set 2 05/27/13, 17:19

  2. Lorenz Ulrich commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Tested with a manipulated FlexForm of EXT:news. Works ad advertised. Without the patch, only the last required input is validated, with the patch, all are.
  3. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  4. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  5. Wouter Wolters uploaded patch set 3 05/28/13, 19:47

  6. Mr. Jenkins commented on patch set 3 05/28/13, 19:48

  7. Benni Mack commented on patch set 3 V -1 07/02/13, 12:53

    Hey Christian, I tried with the media content element, did not work. - no change, only the last field is required.
  8. Christian Weiske commented on patch set 3 07/26/13, 12:56

    @Benjamin: What do you mean with media content element? Could you given some example flexform code?
  9. Lorenz Ulrich commented on patch set 3 11/28/13, 16:09

    @Christian: The Media content element is the content element "Media" (have a close look at the new content element wizard).
  10. Xavier Perseguers commented on patch set 3 V -1 06/10/14, 11:50

    Tried with an extension of mine, does not work. Maybe I don't understand how to reproduce but current behaviour (master) looks fine.
  11. Benni Mack commented on patch set 3 10/18/14, 20:25

    Hey Christian, would you mind updating your patch for master and 6.2? would be great.
  12. Felix Kopp wrote 11/02/14, 23:15

    Topic changed from 17122 to formengine
  13. Benni Mack commented on patch set 3 11/24/14, 18:15

    could you check this one again please?
  14. Mathias Schreiber wrote 12/17/14, 15:03

    Topic changed from formengine to Formengine
  15. Benni Mack commented on patch set 3 CR -1 02/02/15, 21:22

    picking this one up for 7.1.
  16. Xavier Perseguers wrote 03/30/15, 14:13

    Removed the following approvals: * Verified-1 by Xavier Perseguers <xavier@typo3.org>
  17. Christian Weiske abandoned the change 04/21/15, 12:25

    The bug still exists, but don't want to care for that patch anymore.