Review main Merged

17939[FEATURE] TS-list: allow to unique, reverse and sort

Stefan Neufeind CR +2 V +2 Hard +322 −35 updated 06/03/13, 20:49

Commit message

Add missing, basic list-functionality for TypoScript.
Also splits out the TS-operator-functions into a
separate function and adds unit-tests.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 36

Show 11 earlier messages
  1. Stefan Neufeind commented on patch set 1 04/10/13, 17:53

    Imho an easy one, also easy to test. You just need a few lines typoscript and the object-analyser. If people agree to the what and how of this patch, documentation needs to be added before commit. preg is adjusted to allow also empty argument-lists after a function-name. But we should imho still demand the brackets to make clear a function is called.
  2. Stefan Neufeind commented on patch set 1 04/10/13, 17:53

    (1 inline comment)
  3. Stefan Neufeind commented on patch set 1 04/10/13, 17:53

    I probably won't find time to write these testcases on time. I'd however appreciate if that feature could go in and imho it's small enough. Could we agree to merge it now and I'll promise to send a follow-up for tests? Or could somebody else have a look?
  4. Stefan Neufeind commented on patch set 2 04/10/13, 17:53

    as Christian suggested: splitted this out into a separate function and added (basic) unit-tests. Of course more tests would be useful :-)
  5. Stefan Neufeind uploaded patch set 2 04/10/13, 17:53

  6. Stefan Neufeind uploaded patch set 3 04/10/13, 17:53

  7. Stefan Neufeind uploaded patch set 4 04/10/13, 17:53

  8. Stefan Neufeind commented on patch set 4 04/10/13, 17:53

    From patch 2 to 4 only indentions were fixed.
  9. Christian Kuhn commented on patch set 1 04/10/13, 17:53

    I would prefer that you didn't submit this

    TypoScriptParser.php:376

    Please extract this part to some protected method and add unit tests to it.

    TypoScriptParser.php:376 Reply

    yes, probably something like that. at first glance it should be pretty easy to extract the whole thing (if(..) {..}) to a method that gets $line as parameter. even if the case construct then stays inside this method and is not extracted further, it should be easy to feed this method with a set of happy little tests (probably at least one bigger dataprovider) to document the full behavior.
  10. Christian Kuhn commented on patch set 1 04/10/13, 17:53

    (1 inline comment)
  11. Christian Kuhn commented on patch set 1 04/10/13, 17:53

    Mmmh. I still don't think it is a good idea to merge here without tests.
  1. Philipp Gampe commented on patch set 4 04/10/13, 17:53

    (1 inline comment)

    TypoScriptParserTest.php:50

    remove commented code
  2. Philipp Gampe commented on patch set 4 04/10/13, 17:53

    Verified; Looks good to me, but someone else must approve tested with unit tests
  3. Stefan Neufeind uploaded patch set 6 04/10/13, 17:53

  4. Stefan Neufeind commented on patch set 6 04/10/13, 17:53

    please revote. Only removed backupGlobals as mentioned by Wouter
  5. Christian Kuhn commented on patch set 6 04/10/13, 17:53

    I would prefer that you didn't submit this Working on it now.
  6. Stefan Neufeind commented on patch set 7 V 0 04/10/13, 17:53

    Thanks for the whole bunch of tests. Looks great. Ran testcases with success
  7. Christian Kuhn uploaded patch set 7 04/10/13, 17:53

  8. Christian Kuhn commented on patch set 7 04/10/13, 17:53

    Verified; Looks good to me, but someone else must approve
  9. Christian Kuhn commented on patch set 8 V 0 04/10/13, 17:53

    by team member; Looks good to me, approved
  10. Christian Kuhn uploaded patch set 8 04/10/13, 17:53

  11. Christian Kuhn commented on patch set 8 04/10/13, 17:53

    Verified; Looks good to me, but someone else must approve
  12. Christian Kuhn merged patch set 9 04/10/13, 17:53

  13. Philipp Gampe commented on patch set 5 04/10/13, 17:53

    Verified; Looks good to me, but someone else must approve I just removed commented code.
  14. Philipp Gampe uploaded patch set 5 04/10/13, 17:53

  15. Philipp Gampe commented on patch set 8 04/10/13, 17:53

    Verified; Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 1 04/10/13, 17:53

  17. Mr. Jenkins commented on patch set 2 04/10/13, 17:53

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8019/ : FAILURE
  18. Mr. Jenkins commented on patch set 3 04/10/13, 17:53

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8020/ : FAILURE
  19. Mr. Jenkins commented on patch set 4 04/10/13, 17:53

  20. Mr. Jenkins commented on patch set 5 04/10/13, 17:53

  21. Mr. Jenkins commented on patch set 6 04/10/13, 17:53

  22. Mr. Jenkins commented on patch set 7 04/10/13, 17:53

  23. Mr. Jenkins commented on patch set 8 04/10/13, 17:53

  24. Wouter Wolters commented on patch set 5 04/10/13, 17:53

    (1 inline comment)

    TypoScriptParserTest.php:37

    Not needed anymore, removed them lately https://review.typo3.org/#/c/19215/
  25. Chris topher commented on patch set 9 04/10/13, 17:53

    Documentation at #46815 = https://review.typo3.org/19784