Review main Merged

17975[BUGFIX] LanguageController has "mixed" type annotations

Wouter Wolters CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

The LanguageController of the lang sysext throws
exceptions if the rewritten property mapper is enabled.
The type annotation 'mixed' is unknown. The patch fixed
the annotation to the correct string value to make the
property mapper happy.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Files 1

Review log 12

  1. Nico de Haen commented on patch set 1 03/14/13, 19:09

    Did you try what happens if the parameter is an array? I don't know when that is the case. It might throw an exception again.
  2. Christian Kuhn uploaded patch set 2 03/14/13, 19:09

  3. Christian Kuhn commented on patch set 2 03/14/13, 19:09

    Verified; Looks good to me, but someone else must approve
  4. Christian Kuhn uploaded patch set 3 03/14/13, 19:09

  5. Christian Kuhn commented on patch set 3 V 0 03/14/13, 19:09

    by team member; Looks good to me, approved
  6. Christian Kuhn commented on patch set 3 03/14/13, 19:09

    Verified; Looks good to me, but someone else must approve
  7. Anja Leichsenring commented on patch set 3 03/14/13, 19:09

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 03/14/13, 19:09

  9. Mr. Jenkins commented on patch set 3 03/14/13, 19:09

  10. Rico Sonntag commented on patch set 1 03/14/13, 19:09

    Fails; I would prefer that you didn't submit this As the parameter could be array or string the type should be mixed or string|array.
  11. André Haehnel commented on patch set 1 03/14/13, 19:09

    Fails I cant produce the problem. You should change the parameter comment in 'comma separated list' (remove array).
  12. Christian Kuhn merged patch set 4 03/14/13, 19:09