17975[BUGFIX] LanguageController has "mixed" type annotations
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
Files 1
Review log 12
-
Nico de Haen commented on patch set 1 03/14/13, 19:09
Did you try what happens if the parameter is an array? I don't know when that is the case. It might throw an exception again. -
Christian Kuhn uploaded patch set 2 03/14/13, 19:09
-
Christian Kuhn commented on patch set 2 03/14/13, 19:09
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 3 03/14/13, 19:09
-
Christian Kuhn commented on patch set 3 V 0 03/14/13, 19:09
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 3 03/14/13, 19:09
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 3 03/14/13, 19:09
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/14/13, 19:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7315/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/14/13, 19:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7728/ : SUCCESS -
Rico Sonntag commented on patch set 1 03/14/13, 19:09
Fails; I would prefer that you didn't submit this As the parameter could be array or string the type should be mixed or string|array. -
André Haehnel commented on patch set 1 03/14/13, 19:09
Fails I cant produce the problem. You should change the parameter comment in 'comma separated list' (remove array). -
Christian Kuhn merged patch set 4 03/14/13, 19:09