Review main Abandoned

17996[BUGFIX] Object config in MediaWizardProviderManager

Alexander Stehlik CR 0 V 0 Normal +42 −11 updated 08/13/14, 19:03

Commit message

Defer class instantiation in MediaWizardProviderManager so that
all extension configuration files that might alter the object
configuration are loaded before.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 11

  1. Alexander Stehlik uploaded patch set 2 05/27/13, 17:19

  2. Alexander Stehlik uploaded patch set 3 05/27/13, 17:19

  3. Mattias Nilsson commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  5. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  7. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
    IMO drop 4.6 here

    MediaWizardProviderManager.php:53

    @return void missing here
  8. Wouter Wolters uploaded patch set 4 06/29/13, 19:32

  9. Mr. Jenkins commented on patch set 4 06/29/13, 19:33

  10. Christian Kuhn commented on patch set 4 08/13/14, 19:03

    Thanks for the patch, it seems we forgot about this one here, and meanwhile another one evolved at https://review.typo3.org/#/c/28046/ that solves the issue in a very similar way. We will abandon this patch now since the other one was kept updated and is merged now. Thanks for all efforts.
  11. Christian Kuhn abandoned the change 08/13/14, 19:03