Review main Merged

18018[FEATURE] Add a disable/enable button to tasks overview

Thomas Löffler CR +2 V +2 Normal +81 −2 updated 06/03/13, 20:49

Commit message

Adds an option in the task list to enable or disable
a scheduler task.

Review

  • Code review CR +2
    • Ingo Renner +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
    • Thomas Löffler +1
  • Verified V +2
    • Ingo Renner +2
    • Philipp Gampe +1
    • Thomas Löffler +1

Issues 1

Files 2

Review log 20

  1. Christian Kuhn commented on patch set 1 02/24/13, 02:59

    nice. happy little feature. will review soon.
  2. Thomas Löffler uploaded patch set 2 02/24/13, 02:59

  3. Philipp Gampe commented on patch set 2 02/24/13, 02:59

    Fails I will push a fix.

    SchedulerModuleController.php:586

    maynotDisableDisabledTask will push a new version
  4. Ingo Renner commented on patch set 3 V 0 02/24/13, 02:59

    by team member; Looks good to me, approved
  5. Ingo Renner merged patch set 4 02/24/13, 02:59

  6. Stefan Neufeind commented on patch set 3 02/24/13, 02:59

    Looks good to me, but someone else must approve
  7. Christian Kuhn commented on patch set 4 02/24/13, 02:59

    Are you aware that this task introduces some heavy usability issues if combined with 'single execution' tasks or with tasks that have passed their end date? In this case, the lightbulb icon does not change and there is no feedback to the user in list view in any way.
  8. Christian Kuhn commented on patch set 4 02/24/13, 02:59

    The new icon does not have a tooltip, while the other two do have one. Was this done by intention?
  9. Thomas Löffler commented on patch set 3 02/24/13, 02:59

    Verified; Looks good to me, but someone else must approve
  10. Thomas Löffler commented on patch set 4 02/24/13, 02:59

    Not really. I will patch it tomorrow with a seperate bugfix issue.
  11. Philipp Gampe uploaded patch set 3 02/24/13, 02:59

  12. Philipp Gampe commented on patch set 3 02/24/13, 02:59

    Verified; Looks good to me, but someone else must approve
  13. Philipp Gampe commented on patch set 4 02/24/13, 02:59

    This has been broken before. I will create a follow up for this that should sort this out.
  14. Philipp Gampe commented on patch set 4 02/24/13, 02:59

  15. Mr. Jenkins commented on patch set 1 02/24/13, 02:59

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7346/ : FAILURE
  16. Mr. Jenkins commented on patch set 2 02/24/13, 02:59

  17. Mr. Jenkins commented on patch set 3 02/24/13, 02:59

  18. Wouter Wolters commented on patch set 2 02/24/13, 02:59

    Looks good to me, but someone else must approve
  19. Felix Kopp commented on patch set 4 02/24/13, 02:59

    Hey guys, this patch brings a bug: Single execution tasks and tasks after their end date can not be enabled. Those should not have an enable button.
  20. Christian Kuhn commented on patch set 4 04/29/13, 13:36

    Reverted This patchset was reverted in change: I36b5b87ced3fe2769f26bce9a4445d26e5bf1909