Review main Merged

18040[BUGFIX] Wrong SQL statements in TCA for sys_category

Thomas Löffler CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Copy and Paste problem. Table name
'tx_taxonomy_domain_model_concept' instead of
'sys_category'

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Thomas Löffler +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Thomas Löffler +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 12

  1. Thomas Löffler commented on patch set 1 02/06/13, 09:09

    Oops, how did I made this dependency? Can someone help?
  2. Thomas Löffler uploaded patch set 2 02/06/13, 09:09

  3. Thomas Löffler commented on patch set 2 02/06/13, 09:09

    Thanks, found the right command to get a clean master. ;)
  4. Thomas Löffler commented on patch set 2 02/06/13, 09:09

    Verified; Looks good to me, but someone else must approve
  5. Philipp Gampe commented on patch set 2 02/06/13, 09:09

    Verified; Looks good to me, but someone else must approve @Thomas you can not vote for your own patch
  6. Mr. Jenkins commented on patch set 1 02/06/13, 09:09

  7. Mr. Jenkins commented on patch set 2 02/06/13, 09:09

  8. Wouter Wolters commented on patch set 1 02/06/13, 09:09

    Looks good to me, but someone else must approve Can you remove the dependency?
  9. Wouter Wolters commented on patch set 2 02/06/13, 09:09

    Always start a new patch on a clean master:) Then this will not happen. Now you changed it above the Feature you created and pushed it, then the dependency is set.
  10. Wouter Wolters commented on patch set 2 02/06/13, 09:09

    Looks good to me, but someone else must approve
  11. Christian Kuhn commented on patch set 2 V 0 02/06/13, 09:09

    by team member; Looks good to me, approved
  12. Christian Kuhn merged patch set 3 02/06/13, 09:09