1808[FEATURE] Add possibility to include files for the global variable scope
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 6
-
Stefan Neufeind commented on patch set 1 06/13/11, 17:10
Oliver, could you give this a short discussion with Steffen maybe? -
Markus Klein commented on patch set 1 06/13/11, 17:10
(1 inline comment)class.t3lib_div.php:5263What about all the other global variables e.g. in t3lib/stddb/tables.php? $PAGES_TYPES, $ICON_TYPES, $FILEICONS, etc. -
Markus Klein commented on patch set 1 06/13/11, 17:10
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 1 06/13/11, 17:10
I would prefer that you didn't submit this Sorry, I don't see the real benefit of having these two-line functions. Adding the "global $var" directly where the include happens (where it has been before the cleanup), would be IMHO more transparent, what variables are expected there. -
Mr. Jenkins commented on patch set 1 06/13/11, 17:10
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/405/ : SUCCESS -
Oliver Hader commented on patch set 1 06/13/11, 17:10
Abandoned The related bug was fixed in between