Review main Abandoned

1808[FEATURE] Add possibility to include files for the global variable scope

Oliver Hader CR 0 V 0 Easy +28 −0 updated 06/03/13, 20:49

Commit message

PHP files can be included from a method/function by taking TYPO3 specific
global variables like $T3_SERVICES, $T3_VAR, $TYPO3_CONF_VARS, $TCA into
account.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Stefan Neufeind commented on patch set 1 06/13/11, 17:10

    Oliver, could you give this a short discussion with Steffen maybe?
  2. Markus Klein commented on patch set 1 06/13/11, 17:10

    (1 inline comment)

    class.t3lib_div.php:5263

    What about all the other global variables e.g. in t3lib/stddb/tables.php? $PAGES_TYPES, $ICON_TYPES, $FILEICONS, etc.
  3. Markus Klein commented on patch set 1 06/13/11, 17:10

    Verified; Looks good to me, but someone else must approve
  4. Steffen Gebert commented on patch set 1 06/13/11, 17:10

    I would prefer that you didn't submit this Sorry, I don't see the real benefit of having these two-line functions. Adding the "global $var" directly where the include happens (where it has been before the cleanup), would be IMHO more transparent, what variables are expected there.
  5. Mr. Jenkins commented on patch set 1 06/13/11, 17:10

  6. Oliver Hader commented on patch set 1 06/13/11, 17:10

    Abandoned The related bug was fixed in between