Review main Merged

18082[FEATURE] Click the whole row to de-/select a task

Thomas Löffler CR +2 V +2 Easy +19 −3 updated 06/03/13, 20:49

Commit message

To select or deselect a task you only need
to click in the row.

Review

  • Code review CR +2
    • Ingo Renner +2
  • Verified V +2
    • Ingo Renner +2

Issues 1

Files 1

Review log 17

  1. Ingo Renner commented on patch set 1 02/16/13, 23:33

    Looks good to me, but someone else must approve
  2. Thomas Löffler commented on patch set 1 02/16/13, 23:33

    Fails Now the direct click on the checkbox isn't working any more.
  3. Ingo Renner commented on patch set 2 02/16/13, 23:33

    Usually I'd agree, but I think these changes are so minor and so obvious, there's no need to bug these guys with that.
  4. Ingo Renner commented on patch set 2 02/16/13, 23:33

    Rebased
  5. Ingo Renner uploaded patch set 4 02/16/13, 23:33

  6. Ingo Renner uploaded patch set 5 02/16/13, 23:33

  7. Ingo Renner commented on patch set 5 V 0 02/16/13, 23:33

    by team member; Looks good to me, approved rebased, minor cleanup, prevented the selection behavior when clicking one of the action icons. merged as no-brainer
  8. Stefan Neufeind commented on patch set 2 02/16/13, 23:33

    If it can be done easily to get a feedback from them fine. Otherwise I'm with Ingo - let's get this going imho.
  9. Christian Kuhn commented on patch set 2 02/16/13, 23:33

    I would prefer that you didn't submit this @Thomas: If you are changing so many details is the list view of the scheduler (which is cool, since in really can be improved a lot). Would you please try to contact the usability team about this, maybe by direct contact to Felix Kopp? I'd appreciate any input in this area from him.
  10. Thomas Löffler uploaded patch set 2 02/16/13, 23:33

  11. Mr. Jenkins commented on patch set 1 02/16/13, 23:33

  12. Mr. Jenkins commented on patch set 2 02/16/13, 23:33

  13. Mr. Jenkins commented on patch set 3 02/16/13, 23:33

  14. Mr. Jenkins commented on patch set 4 02/16/13, 23:33

  15. Mr. Jenkins commented on patch set 5 02/16/13, 23:33

  16. Wouter Wolters commented on patch set 2 02/16/13, 23:33

    Check also this ticket. http://forge.typo3.org/issues/32752
  17. Ingo Renner merged patch set 6 02/16/13, 23:33