1810[FEATURE] Add option to remove default CSS from extensions
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Stefan Neufeind +1
- Georg Ringer +1
- Markus Klein +1
- Dmitry Dulepov +1
-
Verified V +2
- Andreas Wolf +2
- Georg Ringer +1
- Markus Klein +1
Issues 1
Files 1
Review log 13
-
Andreas Wolf merged patch set 1 06/08/11, 19:35
-
Andreas Wolf commented on patch set 1 V 0 06/08/11, 19:35
by team member; Looks good to me, approved Pushing this after two positive votes. Btw., I can confirm Susannes last statement: if (!$someEmptyVar) {} throws a NOTICE, while (empty($someEmptyVar)) doesn't. Even if we currently use !, we should strive to get rid of as many warnings and notices as possible. -
Dmitry Dulepov commented on patch set 1 1 comment 06/08/11, 19:35
Looks good to me, but someone else must approve See my inline comment though. -
Dmitry Dulepov commented on patch set 1 06/08/11, 19:35
See my inline comment though. -
Stefan Neufeind commented on patch set 1 06/08/11, 19:35
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 1 06/08/11, 19:35
I would prefer that you didn't submit thisclass.tslib_pagegen.php:513Why are you checking this with empty()? Setting config.removeDefaultCss = 0 will also disable then. Suggestion: && !isset($GLOBALS['TSFE']->config['config']['removeDefaultCss']) && !$GLOBALS['TSFE']->co nfig['config']['removeDefaultCss'] -
Markus Klein commented on patch set 1 06/08/11, 19:35
Looks good to me, but someone else must approve You're right, I'm sorry. I remembered this wrong. -
Markus Klein commented on patch set 1 V 0 06/08/11, 19:35
Maybe we should call this option "removeDefaultCSS", since there's already "removeDefaultJS". -
Susi Moog commented on patch set 1 06/08/11, 19:35
(1 inline comment)class.tslib_pagegen.php:513ReplyNope, empty is correct here - as the documentation states: http://de3.php.net/manual/en/function.empty.php Returns FALSE if var has a non-empty and non-zero value. The following things are considered to be empty: "" (an empty string) 0 (0 as an integer) 0.0 (0 as a float) "0" (0 as a string) NULL FALSE array() (an empty array) var $var; (a variable declared, but without a value in a class) You can test it, config.removeDefaultCss = 0 still inserts the css.class.tslib_pagegen.php:513Replyas far as I know ! throws a php notice if the array is not set while empty does not throw the notice. but I'll look it up again. -
Susi Moog commented on patch set 1 06/08/11, 19:35
(1 inline comment) -
Georg Ringer commented on patch set 1 06/08/11, 19:35
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 06/08/11, 19:35
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/408/ : SUCCESS -
Francois Suter commented on patch set 1 06/08/11, 19:35
Please add the relevant documentation to the pending documentation page in the wiki (section doc_core_tsconfig 4.6): http://wiki.typo3.org/Pending_Documentation#doc_core_tsconfig_.284.6.29