Review main Merged

18121[TASK] Enable "pageNotFoundOnCHashError" by default

Georg Ringer CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The setting pageNotFoundOnCHashError should be true by default for
perfomance reasons: If it is true, a 404 error is thrown when an invalid
cHash is found. This is way faster than re-rendering an otherwise cached
page (and then not caching it because of the invalid cHash).

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 6

  1. Thorsten Kahler commented on patch set 1 02/09/13, 22:33

    Verified; Looks good to me, but someone else must approve
  2. Andreas Wolf commented on patch set 1 V 0 02/09/13, 22:33

    by team member; Looks good to me, approved Adjusted commit message to be more clear about what this patch does.
  3. Andreas Wolf uploaded patch set 2 02/09/13, 22:33

  4. Andreas Wolf commented on patch set 2 V 0 02/09/13, 22:33

    by team member; Looks good to me, approved
  5. Mr. Jenkins commented on patch set 1 02/09/13, 22:33

  6. Andreas Wolf merged patch set 3 02/09/13, 22:33