Review main Merged

1813[BUGFIX] Add stdWrap for excludeUidList for HMENU.

mostwanted CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • Chris topher +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Chris topher +1
    • Benni Mack +1

Issues 1

Files 1

Review log 20

  1. Markus Klein commented on patch set 1 05/29/11, 18:01

    Looks good to me, but someone else must approve
  2. Benni Mack commented on patch set 1 05/29/11, 18:01

    Looks good to me, but someone else must approve seems a good place to do that.
  3. Benni Mack commented on patch set 1 05/29/11, 18:01

    seems a good place to do that.
  4. Benni Mack commented on patch set 1 05/29/11, 18:01

    Verified; No score yes. nice stuff, works as expected.
  5. Oliver Hader commented on patch set 1 05/29/11, 18:01

    Looks good to me, approved
  6. Oliver Hader commented on patch set 1 05/29/11, 18:01

    Please make sure to add this additional feature to the Wiki Page of pending documentation: http://wiki.typo3.org/Pending_Documentation
  7. Oliver Hader commented on patch set 1 05/29/11, 18:01

    Looks good to me, but someone else must approve
  8. mostwanted commented on patch set 1 05/29/11, 18:01

    @oliver: i added this additional feature to the Wiki Page of pending documentation. @christopher: i also think this should go to 4.5 - would be great if this could be part of 4.5.3. @christian: i tried to change the realname into my real name. it was set to my alias after some time automatically, but i got some good advice how this should work. i will try to get this work.
  9. Stefan Neufeind commented on patch set 2 05/29/11, 18:01

    Looks good to me, but someone else must approve Patch Set 2: Looks good to me
  10. Markus Klein commented on patch set 2 05/29/11, 18:01

    Looks good to me, but someone else must approve
  11. Benni Mack commented on patch set 2 05/29/11, 18:01

    Verified; Looks good to me, but someone else must approve
  12. Susi Moog commented on patch set 2 V 0 05/29/11, 18:01

    by team member; Looks good to me, approved
  13. mostwanted uploaded patch set 2 05/29/11, 18:01

  14. mostwanted commented on patch set 2 05/29/11, 18:01

    I just pushed my change request with my real name and corrected "added" to "Add" as i was asked to do so by a core developer.
  15. Christian Kuhn commented on patch set 1 05/29/11, 18:01

    Please add a real realname ...
  16. Chris topher commented on patch set 1 05/29/11, 18:01

    Should this also go to 4.5? One could say that it is a bug, that sdtWrap for excludeUidList was forgotten with the "stdWrap everywhere" project.
  17. Chris topher commented on patch set 2 05/29/11, 18:01

    Verified; Looks good to me, but someone else must approve
  18. Mr. Jenkins commented on patch set 1 05/29/11, 18:01

  19. Mr. Jenkins commented on patch set 2 05/29/11, 18:01

  20. Susi Moog merged patch set 2 05/29/11, 18:01