1813[BUGFIX] Add stdWrap for excludeUidList for HMENU.
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Stefan Neufeind +1
- Chris topher +1
- Markus Klein +1
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Chris topher +1
- Benni Mack +1
Issues 1
Files 1
Review log 20
-
Markus Klein commented on patch set 1 05/29/11, 18:01
Looks good to me, but someone else must approve -
Benni Mack commented on patch set 1 05/29/11, 18:01
Looks good to me, but someone else must approve seems a good place to do that. -
Benni Mack commented on patch set 1 05/29/11, 18:01
seems a good place to do that. -
Benni Mack commented on patch set 1 05/29/11, 18:01
Verified; No score yes. nice stuff, works as expected. -
Oliver Hader commented on patch set 1 05/29/11, 18:01
Looks good to me, approved -
Oliver Hader commented on patch set 1 05/29/11, 18:01
Please make sure to add this additional feature to the Wiki Page of pending documentation: http://wiki.typo3.org/Pending_Documentation -
Oliver Hader commented on patch set 1 05/29/11, 18:01
Looks good to me, but someone else must approve -
mostwanted commented on patch set 1 05/29/11, 18:01
@oliver: i added this additional feature to the Wiki Page of pending documentation. @christopher: i also think this should go to 4.5 - would be great if this could be part of 4.5.3. @christian: i tried to change the realname into my real name. it was set to my alias after some time automatically, but i got some good advice how this should work. i will try to get this work. -
Stefan Neufeind commented on patch set 2 05/29/11, 18:01
Looks good to me, but someone else must approve Patch Set 2: Looks good to me -
Markus Klein commented on patch set 2 05/29/11, 18:01
Looks good to me, but someone else must approve -
Benni Mack commented on patch set 2 05/29/11, 18:01
Verified; Looks good to me, but someone else must approve -
Susi Moog commented on patch set 2 V 0 05/29/11, 18:01
by team member; Looks good to me, approved -
mostwanted uploaded patch set 2 05/29/11, 18:01
-
mostwanted commented on patch set 2 05/29/11, 18:01
I just pushed my change request with my real name and corrected "added" to "Add" as i was asked to do so by a core developer. -
Christian Kuhn commented on patch set 1 05/29/11, 18:01
Please add a real realname ... -
Chris topher commented on patch set 1 05/29/11, 18:01
Should this also go to 4.5? One could say that it is a bug, that sdtWrap for excludeUidList was forgotten with the "stdWrap everywhere" project. -
Chris topher commented on patch set 2 05/29/11, 18:01
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/29/11, 18:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/410/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/29/11, 18:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/418/ : SUCCESS -
Susi Moog merged patch set 2 05/29/11, 18:01