18166[TASK] Deprecate TimeTracker
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 28
- typo3/sysext/cms/tslib/index_ts.php+21 −28
- typo3/sysext/cms/tslib/pagegen.php+1 −4
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+0 −5
- typo3/sysext/core/Classes/Error/ErrorHandler.php+0 −4
- typo3/sysext/core/Classes/Resource/Service/ImageProcessingService.php+0 −2
- typo3/sysext/core/Classes/Service/AbstractService.php+0 −3
- typo3/sysext/core/Classes/TimeTracker/NullTimeTracker.php+10 −9
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+15 −0
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+0 −4
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+0 −37
- typo3/sysext/form/Classes/Domain/Factory/TypoScriptFactory.php+0 −2
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+0 −3
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+1 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayContentObject.php+0 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayInternalContentObject.php+0 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+4 −39
- typo3/sysext/frontend/Classes/ContentObject/SearchResultContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/UserContentObject.php+0 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+5 −80
Show 8 more files
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+1 −2
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+0 −31
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+0 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+0 −8
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+0 −6
- typo3/sysext/indexed_search/Classes/Hook/MysqlFulltextIndexHook.php+0 −2
- typo3/sysext/indexed_search/Classes/Indexer.php+0 −9
- typo3/sysext/openid/Classes/OpenidService.php+0 −2
Review log 12
-
Thomas Maroschik uploaded patch set 2 02/12/13, 18:12
-
Thorsten Kahler commented on patch set 3 02/12/13, 18:12
Same here: this has always been a quite useful feature for integrators and we don't have a replacement for it. -
Dmitry Dulepov commented on patch set 3 02/12/13, 18:12
No. This is often used feature. We keep it. -
Oliver Hader commented on patch set 3 02/12/13, 18:12
I would prefer that you didn't submit this I also ask you to not commit this change since I consider the TimeTracker as required. I did not quite understand the reason for using the NullTimeTracker here then - guess for compatibility reasons only. If we wanna remove it, we need alternatives to bring it back (e.g. extracting to an extension or using new hooks, or ...), besides that, we need to use the deprecation strategy for this feature as well. -
Christian Kuhn commented on patch set 3 02/12/13, 18:12
This patch was a quick shot during the extbase sprint. We quickly came to the conclusion that it would be good to have a better solution, but that we also can not just throw the current time and notification system away without substitution. Thats why I already added my -2, which is fully OK with Thomas. I have Thomas freedom to abandon this patch for now. -
Christian Kuhn commented on patch set 3 02/12/13, 18:12
I would prefer that you didn't submit this -
Christian Kuhn commented on patch set 3 02/12/13, 18:12
Do not submit too much impact. this kills an important integrator feature. must be solved differently -
Thomas Maroschik uploaded patch set 3 02/12/13, 18:12
-
Mr. Jenkins commented on patch set 1 02/12/13, 18:12
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7431/ : FAILURE -
Mr. Jenkins commented on patch set 2 02/12/13, 18:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7433/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/12/13, 18:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7434/ : SUCCESS -
Christian Kuhn commented on patch set 3 02/12/13, 18:12
Abandoned will be solved differently.