Review main Abandoned

18166[TASK] Deprecate TimeTracker

Thomas Maroschik CR 0 V 0 Hard +59 −296 updated 06/03/13, 20:49

Commit message

The TimeTracker is one of the oldest parts of TYPO3 and
mostly unused.

During the restructuring of the ContentObjectRenderer and other parts
of the Bootstrap including the patches to the PageRenderer the
TimeTracker didn't get considered at all and still bloats the code.
The traces produced by the TimeTracker are thus incomplete. Profiling
should not be a core tasks of and the TimeTracker deprecated and
removed.

This patch removes all calls on the global TimeTracker and
replaces the global TimeTracker instance by the NullTimeTracker.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 28

Show 8 more files

Review log 12

  1. Thomas Maroschik uploaded patch set 2 02/12/13, 18:12

  2. Thorsten Kahler commented on patch set 3 02/12/13, 18:12

    Same here: this has always been a quite useful feature for integrators and we don't have a replacement for it.
  3. Dmitry Dulepov commented on patch set 3 02/12/13, 18:12

    No. This is often used feature. We keep it.
  4. Oliver Hader commented on patch set 3 02/12/13, 18:12

    I would prefer that you didn't submit this I also ask you to not commit this change since I consider the TimeTracker as required. I did not quite understand the reason for using the NullTimeTracker here then - guess for compatibility reasons only. If we wanna remove it, we need alternatives to bring it back (e.g. extracting to an extension or using new hooks, or ...), besides that, we need to use the deprecation strategy for this feature as well.
  5. Christian Kuhn commented on patch set 3 02/12/13, 18:12

    This patch was a quick shot during the extbase sprint. We quickly came to the conclusion that it would be good to have a better solution, but that we also can not just throw the current time and notification system away without substitution. Thats why I already added my -2, which is fully OK with Thomas. I have Thomas freedom to abandon this patch for now.
  6. Christian Kuhn commented on patch set 3 02/12/13, 18:12

    I would prefer that you didn't submit this
  7. Christian Kuhn commented on patch set 3 02/12/13, 18:12

    Do not submit too much impact. this kills an important integrator feature. must be solved differently
  8. Thomas Maroschik uploaded patch set 3 02/12/13, 18:12

  9. Mr. Jenkins commented on patch set 1 02/12/13, 18:12

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7431/ : FAILURE
  10. Mr. Jenkins commented on patch set 2 02/12/13, 18:12

  11. Mr. Jenkins commented on patch set 3 02/12/13, 18:12

  12. Christian Kuhn commented on patch set 3 02/12/13, 18:12

    Abandoned will be solved differently.