Review main Merged

18178[TASK] Remove not used viewhelper in beuser

Markus Günther CR -1 V +2 Normal +0 −52 updated 06/03/13, 20:49

Commit message

The SelectDefaultValueViewHelper in beuser is
not used at the moment and since TYPO3 fluid
6.1 it is possible to add a prependOption
with the default selectViewHelper.

Review

  • Code review CR -1
    • Helmut Hummel +2
    • Mattias Nilsson -1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1

Files 1

Review log 8

  1. Helmut Hummel commented on patch set 2 V 0 02/10/13, 12:00

    by team member; Looks good to me, approved
  2. Christian Kuhn uploaded patch set 2 02/10/13, 12:00

  3. Christian Kuhn commented on patch set 2 02/10/13, 12:00

    because it is unused in be_user scope and extensions shouldn't use foreign view helpers anyway, if not for some really good reason.
  4. Christian Kuhn commented on patch set 2 02/10/13, 12:00

    Verified; Looks good to me, but someone else must approve
  5. Mattias Nilsson commented on patch set 2 02/10/13, 12:00

    I would prefer that you didn't submit this Why remove something that works?
  6. Mr. Jenkins commented on patch set 1 02/10/13, 12:00

  7. Mr. Jenkins commented on patch set 2 02/10/13, 12:00

  8. Helmut Hummel merged patch set 3 02/10/13, 12:00