18187[TASK] Remove/fix deprecated calls in extensionmanager
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 3
Review log 18
-
Stefan Neufeind commented on patch set 1 04/01/13, 16:02
(1 inline comment) -
Christian Kuhn commented on patch set 1 04/01/13, 16:02
I would prefer that you didn't submit this detail about string / text field must be changed, will take a look soonish.TypoScriptConstantsViewHelper.php:210not the way to go ... -
Markus Günther commented on patch set 1 04/01/13, 16:02
(2 inline comments)Reply
DoneReply
Ok i take some sleep and write the commit message again ;)TypoScriptConstantsViewHelper.php:210ReplyDone -
Markus Günther uploaded patch set 2 04/01/13, 16:02
-
Stefan Neufeind commented on patch set 3 1 comment 04/01/13, 16:02
Looks good to me, but someone else must approve -
Markus Günther commented on patch set 3 04/01/13, 16:02
(1 inline comment) -
Markus Günther uploaded patch set 3 04/01/13, 16:02
-
Christian Kuhn commented on patch set 4 1 comment 04/01/13, 16:02
I would prefer that you didn't submit this The submodule pointer change must be left out. For the possible input types: imho they actually do not really harm, and do they really throw some deprecation somewhere? if not, i think we should remove the comment and let both options just stay in it (maybe with an adapted message: "those two behave like xy" or something). -
Christian Kuhn uploaded patch set 5 04/01/13, 16:02
-
Markus Günther uploaded patch set 4 04/01/13, 16:02
-
Markus Günther commented on patch set 5 04/01/13, 16:02
But we set a value via persistenceManager and not via the repository. Is this not correct? -
Mr. Jenkins commented on patch set 1 04/01/13, 16:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7448/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/01/13, 16:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7453/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/01/13, 16:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7454/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/01/13, 16:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7651/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/01/13, 16:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7893/ : SUCCESS -
Wouter Wolters commented on patch set 5 04/01/13, 16:02
Fails; I would prefer that you didn't submit this Do not merge this one. * querysettings change in commit:4d4b047e: settings are no longer repo specific [!!!] - this should be fixed (mbh) http://git.typo3.org/TYPO3v4/CoreProjects/MVC/extbase.git/commitdiff/4d4b047e8eca2cfd86eef94954066f292277394f -> Alex will provide here before 6.1 beta -
Christian Kuhn commented on patch set 5 04/01/13, 16:02
Abandoned Abandoned: The 'make persistence replacable" patch was reverted. We'll create a new patch if it comes up again.