Review main Abandoned

18197[BUGFIX] Usage of id=pageAlias is broken while logged in in BE

Thorben Nissen CR 0 V 0 Easy +10 −1 updated 09/29/14, 09:53

Commit message

The page alias is not converted to the page id if you are logged in
in the BE. To fix this and correctly handle not existing aliases,
we use \TYPO3\CMS\Frontend\Page\PageRepository::getPageIdFromAlias
to determine the page's uid. If there is no id found for this alias
 - the id is zero - we must not try to get the rootline, this would
cause an exception.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 34

Show 9 earlier messages
  1. Steffen Gebert uploaded patch set 2 05/27/13, 17:19

  2. Markus Klein commented on patch set 3 05/27/13, 17:19

    I would prefer that you didn't submit this * There is already a method doing exactly this: checkAndSetAlias() * This is not the whole story! $this->id might not only be an ID or an ALIAS, but also any content. The actual ID is fixed only after fetch_the_id() has been called. For example any extension might manipulate $this->id in the hook 'modifyPageId'. (simulate static is currently using this) Therefore $this->id might still be valid, but may not contain an ID or an ALIAS at this point in the code. Hence it is plain wrong to set the pageNotFound error here.
  3. Thorben Nissen uploaded patch set 3 05/27/13, 17:19

  4. Thorben Nissen commented on patch set 3 05/27/13, 17:19

    Right, I copied the code from checkAndSetAlias(), because it does not work here due to $this->sys_page not beeing set yet. This is set in fetch_the_id(), but fetch_the_id() is called after determineId(). The setting of the page not found may be wrong. I removed it and tried again. It is set later in checkAndSetAlias() that is called in fetch_the_id(), so it works. Might this be a better solution?
  5. Markus Klein commented on patch set 4 05/27/13, 17:19

    I'm fine with your improvement, but still this whole process of determining fePreview or not is completely wrong. Look at the comment in fetch_the_id(): // Splitting $this->id by a period (.). // First part is 'id' and second part (if exists) will overrule the &type param and // Splitting $this->id by a comma (,). // First part is 'id' and other parts are just stored for use in scripts. IMO this whole id splitting part has to be moved into the determineId() method.
  6. Markus Klein commented on patch set 4 05/27/13, 17:19

    I would prefer that you didn't submit this This needs further inspection by some core devs, since this is a very critical place. I asked Christian to have a look.
  7. Thorben Nissen uploaded patch set 4 05/27/13, 17:19

  8. Thorben Nissen commented on patch set 4 05/27/13, 17:19

    Ok, I'll take a look at that.
  9. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7457/ : FAILURE
  1. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7458/ : SUCCESS
  2. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  3. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  4. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  5. Markus Klein uploaded patch set 5 07/07/13, 23:11

  6. Mr. Jenkins commented on patch set 5 07/07/13, 23:12

  7. Markus Klein uploaded patch set 6 09/26/13, 22:56

  8. Mr. Jenkins commented on patch set 6 09/26/13, 23:16

  9. Markus Klein uploaded patch set 7 12/18/13, 13:40

  10. Markus Klein voted on patch set 7 V +1 CR +1 12/18/13, 13:41

  11. Mr. Jenkins commented on patch set 7 12/18/13, 14:02

  12. Markus Klein rebased onto patch set 7 03/05/14, 18:39

  13. Markus Klein voted on patch set 8 V +1 CR +1 03/05/14, 18:39

  14. Markus Klein commented on patch set 8 V 0 CR 0 03/05/14, 18:49

    Thorben, can you please check, if this is still an issue? I can't reproduce this on current master
  15. Helmut Hummel updated the commit message in patch set 8 03/05/14, 18:49

  16. Helmut Hummel commented on patch set 9 03/05/14, 18:50

    only important bugfixes should go into 6.0 as of now
  17. Mr. Jenkins commented on patch set 8 03/05/14, 18:52

  18. Mr. Jenkins commented on patch set 9 03/05/14, 19:03

  19. Markus Klein commented on patch set 9 03/10/14, 22:59

    I can't reproduce this on master. Please check again, else it's a fix for 6.1 only,
  20. Markus Klein commented on patch set 9 CR -1 03/18/14, 10:41

    Thorben, please check it it is still an issue on current master. (or 6.2beta7)
  21. Alexander Opitz commented on patch set 9 CR -1 07/10/14, 12:44

    Thorben can we abandone this patch or does the issue still exists?
  22. Thorben Nissen commented on patch set 9 07/10/14, 13:08

    I didn't have time to test this, but I will.
  23. Alexander Opitz commented on patch set 9 09/15/14, 13:06

    Hi Torben, what's the state of this patch?
  24. Markus Klein abandoned the change 09/29/14, 09:50

    Abandoned due to missing response
  25. Thorben Nissen commented on patch set 9 09/29/14, 09:53

    Close is ok. I didn't step on this issue recently, so it seems to work now. Sorry for the late reply.