18197[BUGFIX] Usage of id=pageAlias is broken while logged in in BE
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 34
Show 9 earlier messages
-
Steffen Gebert uploaded patch set 2 05/27/13, 17:19
-
Markus Klein commented on patch set 3 05/27/13, 17:19
I would prefer that you didn't submit this * There is already a method doing exactly this: checkAndSetAlias() * This is not the whole story! $this->id might not only be an ID or an ALIAS, but also any content. The actual ID is fixed only after fetch_the_id() has been called. For example any extension might manipulate $this->id in the hook 'modifyPageId'. (simulate static is currently using this) Therefore $this->id might still be valid, but may not contain an ID or an ALIAS at this point in the code. Hence it is plain wrong to set the pageNotFound error here. -
Thorben Nissen uploaded patch set 3 05/27/13, 17:19
-
Thorben Nissen commented on patch set 3 05/27/13, 17:19
Right, I copied the code from checkAndSetAlias(), because it does not work here due to $this->sys_page not beeing set yet. This is set in fetch_the_id(), but fetch_the_id() is called after determineId(). The setting of the page not found may be wrong. I removed it and tried again. It is set later in checkAndSetAlias() that is called in fetch_the_id(), so it works. Might this be a better solution? -
Markus Klein commented on patch set 4 05/27/13, 17:19
I'm fine with your improvement, but still this whole process of determining fePreview or not is completely wrong. Look at the comment in fetch_the_id(): // Splitting $this->id by a period (.). // First part is 'id' and second part (if exists) will overrule the &type param and // Splitting $this->id by a comma (,). // First part is 'id' and other parts are just stored for use in scripts. IMO this whole id splitting part has to be moved into the determineId() method. -
Markus Klein commented on patch set 4 05/27/13, 17:19
I would prefer that you didn't submit this This needs further inspection by some core devs, since this is a very critical place. I asked Christian to have a look. -
Thorben Nissen uploaded patch set 4 05/27/13, 17:19
-
Thorben Nissen commented on patch set 4 05/27/13, 17:19
Ok, I'll take a look at that. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7457/ : FAILURE
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7458/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7459/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7460/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7461/ : SUCCESS -
Markus Klein uploaded patch set 5 07/07/13, 23:11
-
Mr. Jenkins commented on patch set 5 07/07/13, 23:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9526/ : SUCCESS -
Markus Klein uploaded patch set 6 09/26/13, 22:56
-
Mr. Jenkins commented on patch set 6 09/26/13, 23:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10964/ : SUCCESS -
Markus Klein uploaded patch set 7 12/18/13, 13:40
-
Markus Klein voted on patch set 7 V +1 CR +1 12/18/13, 13:41
-
Mr. Jenkins commented on patch set 7 12/18/13, 14:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12619/ : SUCCESS -
Markus Klein rebased onto patch set 7 03/05/14, 18:39
-
Markus Klein voted on patch set 8 V +1 CR +1 03/05/14, 18:39
-
Markus Klein commented on patch set 8 V 0 CR 0 03/05/14, 18:49
Thorben, can you please check, if this is still an issue? I can't reproduce this on current master -
Helmut Hummel updated the commit message in patch set 8 03/05/14, 18:49
-
Helmut Hummel commented on patch set 9 03/05/14, 18:50
only important bugfixes should go into 6.0 as of now -
Mr. Jenkins commented on patch set 8 03/05/14, 18:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14606/ : SUCCESS -
Mr. Jenkins commented on patch set 9 03/05/14, 19:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14607/ : SUCCESS -
Markus Klein commented on patch set 9 03/10/14, 22:59
I can't reproduce this on master. Please check again, else it's a fix for 6.1 only, -
Markus Klein commented on patch set 9 CR -1 03/18/14, 10:41
Thorben, please check it it is still an issue on current master. (or 6.2beta7) -
Alexander Opitz commented on patch set 9 CR -1 07/10/14, 12:44
Thorben can we abandone this patch or does the issue still exists? -
Thorben Nissen commented on patch set 9 07/10/14, 13:08
I didn't have time to test this, but I will. -
Alexander Opitz commented on patch set 9 09/15/14, 13:06
Hi Torben, what's the state of this patch? -
Markus Klein abandoned the change 09/29/14, 09:50
Abandoned due to missing response -
Thorben Nissen commented on patch set 9 09/29/14, 09:53
Close is ok. I didn't step on this issue recently, so it seems to work now. Sorry for the late reply.