Review TYPO3_6-0 Merged

18211[BUGFIX] Numeric translation keys aren't translated right in XML files

Wouter Wolters CR +2 V +2 Normal +54 −17 updated 06/03/13, 20:49

Commit message

When working with the "old" XML based translation files,
numeric keys aren't translated properly.
The reason is, that LocallangXmlParser uses array_merge to combine the
translation arrays of the default language and the current language.
array_merge renumbers numeric keys. Therefore, numeric key in
translation files result in wrong translations in Frontend.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Reinhard Führicht +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Reinhard Führicht +1
    • Wouter Wolters +1

Files 3

Review log 4

  1. Reinhard Führicht commented on patch set 1 03/13/13, 23:16

    Verified; Looks good to me, but someone else must approve
  2. Wouter Wolters commented on patch set 1 03/13/13, 23:16

    Verified; Looks good to me, but someone else must approve Same as in master
  3. Christian Kuhn commented on patch set 1 V 0 03/13/13, 23:16

    by team member; Looks good to me, approved
  4. Christian Kuhn merged patch set 2 03/13/13, 23:16