Review main Merged

18214[BUGFIX] excludeUidList not checked for ifsub state

Thorsten Kahler CR +2 V +2 Normal +67 −1 updated 06/03/13, 20:49

Commit message

For menu item states IFSUB(RO), ACTIFSUB(RO) and CURIFSUB(RO) the
excludeUidList was not checked. If all submenu items are excluded the
menu item doesn't get the "ifsub" state anymore.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Wouter Wolters +1

Files 2

Review log 16

  1. Thorsten Kahler uploaded patch set 2 04/21/13, 21:19

  2. Thorsten Kahler commented on patch set 2 04/21/13, 21:19

    Corrected author.
  3. Dmitry Dulepov commented on patch set 2 04/21/13, 21:19

    Looks good to me, but someone else must approve
  4. Oliver Hader commented on patch set 1 04/21/13, 21:19

    Looks good to me, but someone else must approve Testing will follow
  5. Mr. Jenkins commented on patch set 1 04/21/13, 21:19

  6. Mr. Jenkins commented on patch set 2 04/21/13, 21:19

  7. Wouter Wolters commented on patch set 2 04/21/13, 21:19

    I would prefer that you didn't submit this Will push an update in some minutes.

    AbstractMenuContentObjectTest.php:275

    Missing @param notations

    AbstractMenuContentObjectTest.php:279

    missing space after foreach
  8. Stefan Neufeind commented on patch set 3 04/21/13, 21:19

    Looks good to me, but someone else must approve
  9. Georg Ringer commented on patch set 3 04/21/13, 21:19

    Looks good to me, but someone else must approve
  10. Jigal van Hemert commented on patch set 3 V 0 04/21/13, 21:19

    by team member; Looks good to me, approved
  11. Jigal van Hemert merged patch set 4 04/21/13, 21:19

  12. Jigal van Hemert commented on patch set 4 04/21/13, 21:19

    Mail sent to RMs of earlier branches to ask if they want it included in their releases. Backports waiting for their replies.
  13. Mr. Jenkins commented on patch set 3 04/21/13, 21:19

  14. Wouter Wolters commented on patch set 3 04/21/13, 21:19

    Verified; Looks good to me, but someone else must approve Verified with the unit-test
  15. Wouter Wolters uploaded patch set 3 04/21/13, 21:19

  16. Christian Kuhn commented on patch set 4 04/21/13, 21:19

    This patch breaks tests on php 5.4, see https://travis-ci.org/TYPO3/TYPO3v4-Core/jobs/6469746