18214[BUGFIX] excludeUidList not checked for ifsub state
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2
- Jigal van Hemert +2
- Wouter Wolters +1
Files 2
Review log 16
-
Thorsten Kahler uploaded patch set 2 04/21/13, 21:19
-
Thorsten Kahler commented on patch set 2 04/21/13, 21:19
Corrected author. -
Dmitry Dulepov commented on patch set 2 04/21/13, 21:19
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 1 04/21/13, 21:19
Looks good to me, but someone else must approve Testing will follow -
Mr. Jenkins commented on patch set 1 04/21/13, 21:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7466/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/21/13, 21:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7467/ : SUCCESS -
Wouter Wolters commented on patch set 2 04/21/13, 21:19
I would prefer that you didn't submit this Will push an update in some minutes.AbstractMenuContentObjectTest.php:275Missing @param notationsAbstractMenuContentObjectTest.php:279missing space after foreach -
Stefan Neufeind commented on patch set 3 04/21/13, 21:19
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 3 04/21/13, 21:19
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 3 V 0 04/21/13, 21:19
by team member; Looks good to me, approved -
Jigal van Hemert merged patch set 4 04/21/13, 21:19
-
Jigal van Hemert commented on patch set 4 04/21/13, 21:19
Mail sent to RMs of earlier branches to ask if they want it included in their releases. Backports waiting for their replies. -
Mr. Jenkins commented on patch set 3 04/21/13, 21:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7474/ : SUCCESS -
Wouter Wolters commented on patch set 3 04/21/13, 21:19
Verified; Looks good to me, but someone else must approve Verified with the unit-test -
Wouter Wolters uploaded patch set 3 04/21/13, 21:19
-
Christian Kuhn commented on patch set 4 04/21/13, 21:19
This patch breaks tests on php 5.4, see https://travis-ci.org/TYPO3/TYPO3v4-Core/jobs/6469746