Review main Merged

18219[BUGFIX] Respect line breaks in stdWrap.cropHTML

Alexander Stehlik CR +2 V +2 Easy +16 −4 updated 06/03/13, 20:49

Commit message

By using the PCRE_DOTALL (/s) pattern modifier in the cropHTML
regular expression for preserving HTML entities the dot in the
pattern will include line breaks.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Dmitry Dulepov +1
    • Susi Moog +1
    • Philipp Gampe +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Dmitry Dulepov +1
    • Philipp Gampe +1

Issues 1

Files 2

Review log 10

  1. Dmitry Dulepov commented on patch set 1 04/01/13, 20:15

    Verified; Looks good to me, but someone else must approve
  2. Stefan Neufeind commented on patch set 1 04/01/13, 20:15

    Looks good to me, but someone else must approve
  3. Benni Mack commented on patch set 1 V 0 04/01/13, 20:15

    by team member; Looks good to me, approved enough reviews from the others. merging this, and adding the backports now.
  4. Benni Mack commented on patch set 1 04/01/13, 20:15

    enough reviews.
  5. Susi Moog commented on patch set 1 04/01/13, 20:15

    Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 1 04/01/13, 20:15

    Verified; Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 1 04/01/13, 20:15

    Ping, please merge
  8. Mr. Jenkins commented on patch set 1 04/01/13, 20:15

  9. Wouter Wolters commented on patch set 1 04/01/13, 20:15

    Verified; Looks good to me, but someone else must approve
  10. Benni Mack merged patch set 2 04/01/13, 20:15