Review TYPO3_4-5 Abandoned

18260[BUGFIX] tslib_content_Media does not clean up $conf['file.']

Michiel Roos CR 0 V 0 Easy +1 −0 updated 05/09/15, 15:46

Commit message

When a url is passed to a MEDIA object, a proper
url is extracted. This will make sure a youtube
url is correctly rewritten. The result of the
cleaning action is written to $conf['file'].

When an url is passend in through $conf['file.']
and the url is cleaned, the result is written to
$conf['file'] but the original $conf['file.'] is
left untouched.

When the conf object is passed onto SWFOBJECT
for final rendering, the first property that is
checked is the dirty $conf['file.'] and not the
clean $conf['file'].

Currently this prevents proper rendering of a
video when using a 'file.' object to render a
video url.

The solution is to unset $conf['file.'] after
$conf['file'] has been set.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 5

  1. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  2. Ernesto Baschny commented on patch set 1 CR -1 07/22/13, 17:17

    Is this problem gone with >4.5? In 6.x there are calls like "$conf['file'] = $this->retrieveMediaUrl($videoFallback);" so I expect there to be the same trouble - even thou the code is completely different now, probably because of FAL. Could we agree to "fix" this only for 6.x to focus on that branches first for reviewing and testing?
  3. Michiel Roos commented on patch set 1 02/01/14, 07:52

    Anyone have a clue how to embed a youtube video with TypoScript in 6.2?
  4. Mathias Schreiber wrote 12/17/14, 14:34

    Topic set to EXT: cms
  5. Wouter Wolters abandoned the change 05/09/15, 15:46

    I'm abandoning this one. Migrate to 6.2 :-)