Review main Abandoned

18265[FEATURE] Display error messages when running imagemagick commands

Lucas Jenß CR 0 V 0 Easy +38 −8 updated 10/14/13, 13:02

Commit message

When the install tool searches for image magick installations, it now
displays all command line errors what are encountered when trying to
run the image magick commands, such as missing library errors and so on.
This makes it easier to get an image magick installation up and running
if the TYPO3 installer does not seem to detect image magick, where it
actually just has trouble executing the command.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    (1 inline comment)

    Installer.php:2641

    one less tab for indention on 6.0+
  2. Alexander Opitz commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  3. Lucas Jenß uploaded patch set 2 05/27/13, 17:19

  4. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  5. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  6. Christian Kuhn commented on patch set 2 CR -1 10/14/13, 12:58

    This is solved differently in 6.2 install tool. i think we should abandon this one here and only go back to it if it is still an issue (which i doubt).
  7. Christian Kuhn abandoned the change 10/14/13, 13:01

    Since the 6.2 version would need a rewrite of the patch, this version here is abandoned for now.
  8. Wouter Wolters commented on patch set 2 10/14/13, 13:02

    Agreed. We did alot to prevent issues inside the new Install Tool.