18297[TASK] Update file type according to Iana standard
Commit message
Review
-
Code review CR +2
- Benni Mack +2
-
Verified V +2
- Benni Mack +2
Files 3
Review log 20
-
Stefan Neufeind commented on patch set 1 03/22/13, 17:36
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 1 03/22/13, 17:36
Verified; Looks good to me, but someone else must approve No need to test this. In case you push again, please don't forget to specify the Topic. -
Philipp Gampe commented on patch set 1 03/22/13, 17:36
(1 inline comment) Another occurrence is in typo3/sysext/cms/tbl_tt_content.php line 701AbstractFile.php:299This needs to be adjusted too! -
Philipp Gampe commented on patch set 1 03/22/13, 17:36
I would prefer that you didn't submit this -
Dmitry Dulepov commented on patch set 2 03/22/13, 17:36
Looks good to me, approved -
Stefan Neufeind commented on patch set 2 03/22/13, 17:36
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 03/22/13, 17:36
Not really much to "test" here. Could some core-dev please consider this one? -
Markus Klein commented on patch set 2 03/22/13, 17:36
Looks good to me, but someone else must approve Fabien, please always add the TOPIC when you push. ... :/refs/for/master/<forge#> -
Markus Klein commented on patch set 2 03/22/13, 17:36
Sorry for being so short in my comment. You can find the relevant documentation here: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine Specifically: git push origin HEAD:refs/for/<release-branch>/<topic> The Topic is displayed in the metadata box to the left of the commit message above, where it says Owner, Project, Branch, Topic, and so on. -
Oliver Klee commented on patch set 2 03/22/13, 17:36
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 03/22/13, 17:36
Looks good to me, but someone else must approve -
Fabien Udriot uploaded patch set 2 03/22/13, 17:36
-
Fabien Udriot commented on patch set 2 03/22/13, 17:36
I though you were saying mentioning the topic in the description which is something I updated. Still not sure to see exactly... Where do I see the TOPIC in this commit for instance? It looks I need more explanation or a pointer... -
Fabien Udriot commented on patch set 2 03/22/13, 17:36
Allright, got it! -
Benni Mack commented on patch set 3 V 0 03/22/13, 17:36
by team member; Looks good to me, approved Last change was just to adapt to the new locations of the files. So this one is fine now. -
Fabien Udriot uploaded patch set 3 03/22/13, 17:36
-
Mr. Jenkins commented on patch set 1 03/22/13, 17:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7501/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/22/13, 17:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7533/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/22/13, 17:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7871/ : SUCCESS -
Benni Mack merged patch set 4 03/22/13, 17:36