Review main Merged

18297[TASK] Update file type according to Iana standard

Fabien Udriot CR +2 V +2 Easy +20 −3 updated 06/03/13, 20:49

Commit message

This change relates to the File types in FAL.
The Iana standard http://www.iana.org/assignments/media-types
defines a list of Media types which are followed in TYPO3 CMS.
It looks the "Software" type should be deprecated and replaced by
"Application". This matches the mime-type e.g application/pdf and
sounds more comprehensive.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Files 3

Review log 20

  1. Stefan Neufeind commented on patch set 1 03/22/13, 17:36

    Looks good to me, but someone else must approve
  2. Markus Klein commented on patch set 1 03/22/13, 17:36

    Verified; Looks good to me, but someone else must approve No need to test this. In case you push again, please don't forget to specify the Topic.
  3. Philipp Gampe commented on patch set 1 03/22/13, 17:36

    (1 inline comment) Another occurrence is in typo3/sysext/cms/tbl_tt_content.php line 701

    AbstractFile.php:299

    This needs to be adjusted too!
  4. Philipp Gampe commented on patch set 1 03/22/13, 17:36

    I would prefer that you didn't submit this
  5. Dmitry Dulepov commented on patch set 2 03/22/13, 17:36

    Looks good to me, approved
  6. Stefan Neufeind commented on patch set 2 03/22/13, 17:36

    Looks good to me, but someone else must approve
  7. Stefan Neufeind commented on patch set 2 03/22/13, 17:36

    Not really much to "test" here. Could some core-dev please consider this one?
  8. Markus Klein commented on patch set 2 03/22/13, 17:36

    Looks good to me, but someone else must approve Fabien, please always add the TOPIC when you push. ... :/refs/for/master/<forge#>
  9. Markus Klein commented on patch set 2 03/22/13, 17:36

    Sorry for being so short in my comment. You can find the relevant documentation here: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine Specifically: git push origin HEAD:refs/for/<release-branch>/<topic> The Topic is displayed in the metadata box to the left of the commit message above, where it says Owner, Project, Branch, Topic, and so on.
  10. Oliver Klee commented on patch set 2 03/22/13, 17:36

    Looks good to me, but someone else must approve
  11. Philipp Gampe commented on patch set 2 03/22/13, 17:36

    Looks good to me, but someone else must approve
  12. Fabien Udriot uploaded patch set 2 03/22/13, 17:36

  13. Fabien Udriot commented on patch set 2 03/22/13, 17:36

    I though you were saying mentioning the topic in the description which is something I updated. Still not sure to see exactly... Where do I see the TOPIC in this commit for instance? It looks I need more explanation or a pointer...
  14. Fabien Udriot commented on patch set 2 03/22/13, 17:36

    Allright, got it!
  15. Benni Mack commented on patch set 3 V 0 03/22/13, 17:36

    by team member; Looks good to me, approved Last change was just to adapt to the new locations of the files. So this one is fine now.
  16. Fabien Udriot uploaded patch set 3 03/22/13, 17:36

  17. Mr. Jenkins commented on patch set 1 03/22/13, 17:36

  18. Mr. Jenkins commented on patch set 2 03/22/13, 17:36

  19. Mr. Jenkins commented on patch set 3 03/22/13, 17:36

  20. Benni Mack merged patch set 4 03/22/13, 17:36