18313[TASK] Remove old JS in page header
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
- Wouter Wolters +1
- Anja Leichsenring +1
- Henrik Ziegenhain +1
- Dmitry Dulepov +1
- Thomas Löffler +1
-
Verified V +2
- Dmitry Dulepov +2
- Benni Mack +2
- Anja Leichsenring +1
Issues 1
Files 2
Review log 19
-
Markus Klein commented on patch set 1 03/16/13, 16:05
I would prefer that you didn't submit this still referenced in some files. will push new version. -
Dmitry Dulepov uploaded patch set 3 03/16/13, 16:05
-
Dmitry Dulepov commented on patch set 3 V 0 03/16/13, 16:05
by team member; Looks good to me, but someone else must approve Fixed a small issue: empty inline js files were created. -
Markus Klein uploaded patch set 2 03/16/13, 16:05
-
Markus Klein commented on patch set 3 03/16/13, 16:05
Looks good to me, but someone else must approve -
Benni Mack commented on patch set 3 V 0 03/16/13, 16:05
by team member; Looks good to me, approved -
Oliver Klee commented on patch set 2 03/16/13, 16:05
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 3 03/16/13, 16:05
Looks good to me, but someone else must approve -
Thomas Löffler commented on patch set 2 03/16/13, 16:05
Verified; Looks good to me, but someone else must approve -
Thomas Löffler commented on patch set 3 03/16/13, 16:05
Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 2 03/16/13, 16:05
Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 2 03/16/13, 16:05
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 3 03/16/13, 16:05
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/16/13, 16:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7508/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/16/13, 16:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7513/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/16/13, 16:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7538/ : SUCCESS -
Wouter Wolters commented on patch set 3 03/16/13, 16:05
Looks good to me, but someone else must approve -
Benni Mack merged patch set 4 03/16/13, 16:05
-
Henrik Ziegenhain commented on patch set 3 01/06/19, 11:15
Looks good to me, but someone else must approve