Review main Merged

18313[TASK] Remove old JS in page header

Georg Ringer CR +2 V +2 Easy +8 −19 updated 01/06/19, 11:15

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Henrik Ziegenhain +1
    • Dmitry Dulepov +1
    • Thomas Löffler +1
  • Verified V +2
    • Dmitry Dulepov +2
    • Benni Mack +2
    • Anja Leichsenring +1

Issues 1

Files 2

Review log 19

  1. Markus Klein commented on patch set 1 03/16/13, 16:05

    I would prefer that you didn't submit this still referenced in some files. will push new version.
  2. Dmitry Dulepov uploaded patch set 3 03/16/13, 16:05

  3. Dmitry Dulepov commented on patch set 3 V 0 03/16/13, 16:05

    by team member; Looks good to me, but someone else must approve Fixed a small issue: empty inline js files were created.
  4. Markus Klein uploaded patch set 2 03/16/13, 16:05

  5. Markus Klein commented on patch set 3 03/16/13, 16:05

    Looks good to me, but someone else must approve
  6. Benni Mack commented on patch set 3 V 0 03/16/13, 16:05

    by team member; Looks good to me, approved
  7. Oliver Klee commented on patch set 2 03/16/13, 16:05

    Looks good to me, but someone else must approve
  8. Oliver Klee commented on patch set 3 03/16/13, 16:05

    Looks good to me, but someone else must approve
  9. Thomas Löffler commented on patch set 2 03/16/13, 16:05

    Verified; Looks good to me, but someone else must approve
  10. Thomas Löffler commented on patch set 3 03/16/13, 16:05

    Looks good to me, but someone else must approve
  11. Felix Kopp commented on patch set 2 03/16/13, 16:05

    Looks good to me, but someone else must approve
  12. Mattias Nilsson commented on patch set 2 03/16/13, 16:05

    Verified; Looks good to me, but someone else must approve
  13. Anja Leichsenring commented on patch set 3 03/16/13, 16:05

    Verified; Looks good to me, but someone else must approve
  14. Mr. Jenkins commented on patch set 1 03/16/13, 16:05

  15. Mr. Jenkins commented on patch set 2 03/16/13, 16:05

  16. Mr. Jenkins commented on patch set 3 03/16/13, 16:05

  17. Wouter Wolters commented on patch set 3 03/16/13, 16:05

    Looks good to me, but someone else must approve
  18. Benni Mack merged patch set 4 03/16/13, 16:05

  19. Henrik Ziegenhain commented on patch set 3 01/06/19, 11:15

    Looks good to me, but someone else must approve