18314[TASK] Improve rootline cache handling
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Christian Kuhn +2
- Oliver Klee +1
- Wouter Wolters +1
- Oliver Hader +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 1
Review log 8
-
Oliver Klee commented on patch set 1 03/13/13, 21:05
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 1 03/13/13, 21:05
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 1 03/13/13, 21:05
Looks good to me, approved -
Philipp Gampe commented on patch set 1 03/13/13, 21:05
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/13/13, 21:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7509/ : SUCCESS -
Wouter Wolters commented on patch set 1 03/13/13, 21:05
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 V 0 03/13/13, 21:05
by team member; Looks good to me, approved Obvious. merged. rootline is also *always* an array in the cache, so we definatly have no problems with FALSE / NULL / void return values of cache->get() (the caching framework is also not clean in this area). -
Christian Kuhn merged patch set 2 03/13/13, 21:05