Review main Merged

18314[TASK] Improve rootline cache handling

Georg Ringer CR +2 V +2 Easy +4 −3 updated 06/03/13, 20:49

Commit message

The method get() checks if there is an entry by using
has() and does then an additional get(). This can
be simplified which saves a query for every hit

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Oliver Hader +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 8

  1. Oliver Klee commented on patch set 1 03/13/13, 21:05

    Looks good to me, but someone else must approve
  2. Oliver Hader commented on patch set 1 03/13/13, 21:05

    Looks good to me, but someone else must approve
  3. Steffen Ritter commented on patch set 1 03/13/13, 21:05

    Looks good to me, approved
  4. Philipp Gampe commented on patch set 1 03/13/13, 21:05

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 03/13/13, 21:05

  6. Wouter Wolters commented on patch set 1 03/13/13, 21:05

    Looks good to me, but someone else must approve
  7. Christian Kuhn commented on patch set 1 V 0 03/13/13, 21:05

    by team member; Looks good to me, approved Obvious. merged. rootline is also *always* an array in the cache, so we definatly have no problems with FALSE / NULL / void return values of cache->get() (the caching framework is also not clean in this area).
  8. Christian Kuhn merged patch set 2 03/13/13, 21:05