Review TYPO3_4-7 Merged

18324[BUGFIX] Install Tool: Error message gives wrong info

Thomas Löffler CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Based on issue #45135 the change not only includes the
check for the variable length for typo_db_password, but
for typo_db, typo_db_host and typo_db_username as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1

Issues 1

Files 1

Review log 10

  1. Markus Klein commented on patch set 1 03/07/13, 23:40

    Are you sure this only affects 4.7?
  2. Thomas Löffler commented on patch set 1 03/07/13, 23:40

    I just looked for the other versions and I will submit a new patch set in a few seconds. ;)
  3. Markus Klein commented on patch set 2 03/07/13, 23:40

    Fails; I would prefer that you didn't submit this 4.5 and 4.6 affected too. Please push for master first. Blocking this, until master is merged.
  4. Thomas Löffler uploaded patch set 2 03/07/13, 23:40

  5. Markus Klein commented on patch set 3 03/07/13, 23:40

    Fails; I would prefer that you didn't submit this Blocked until master is merged.
  6. Markus Klein commented on patch set 3 03/07/13, 23:40

    Verified; Looks good to me, but someone else must approve Master is merged.
  7. Thomas Löffler uploaded patch set 3 03/07/13, 23:40

  8. Wouter Wolters commented on patch set 3 03/07/13, 23:40

    Verified; Looks good to me, but someone else must approve
  9. Christian Kuhn commented on patch set 3 V 0 03/07/13, 23:40

    by team member; Looks good to me, approved
  10. Christian Kuhn merged patch set 4 03/07/13, 23:40