Review main Merged

18326[BUGFIX] Install Tool: Error message gives wrong info

Thomas Löffler CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Based on issue #45135 the change not only includes the
check for the variable length for typo_db_password, but
for typo_db, typo_db_host and typo_db_username as well.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1

Issues 1

Files 1

Review log 7

  1. Markus Klein commented on patch set 2 02/17/13, 11:17

    Fails; I would prefer that you didn't submit this Blocked until master is merged.
  2. Markus Klein commented on patch set 2 02/17/13, 11:17

    Verified; Looks good to me, but someone else must approve
  3. Thomas Löffler uploaded patch set 2 02/17/13, 11:17

  4. Mr. Jenkins commented on patch set 1 02/17/13, 11:17

  5. Mr. Jenkins commented on patch set 2 02/17/13, 11:17

  6. Georg Ringer commented on patch set 2 V 0 02/17/13, 11:17

    by team member; Looks good to me, approved
  7. Georg Ringer merged patch set 3 02/17/13, 11:17