Review TYPO3_4-5 Merged

18327[BUGFIX] Install Tool: Error message gives wrong info

Thomas Löffler CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Based on issue #45135 the change not only includes the
check for the variable length for typo_db_password, but
for typo_db, typo_db_host and typo_db_username as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1

Issues 1

Files 1

Review log 5

  1. Markus Klein commented on patch set 1 03/07/13, 23:40

    Fails; I would prefer that you didn't submit this Blocked until master is merged.
  2. Markus Klein commented on patch set 1 03/07/13, 23:40

    Verified; Looks good to me, but someone else must approve Master is merged.
  3. Wouter Wolters commented on patch set 1 03/07/13, 23:40

    Verified; Looks good to me, but someone else must approve
  4. Christian Kuhn commented on patch set 1 V 0 03/07/13, 23:40

    by team member; Looks good to me, approved
  5. Christian Kuhn merged patch set 2 03/07/13, 23:40