Review main Merged

18346[BUGFIX] Fix errors in sys_note annotation

Georg Ringer CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

An exception is thrown because the pidlist is annotated with
"mixed" which can't be resolved by extbase. Therefore it must
be changed to "string".

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Helmut Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Helmut Hummel +1

Files 2

Review log 6

  1. Oliver Klee commented on patch set 1 02/18/13, 22:05

    Looks good to me, but someone else must approve
  2. Helmut Hummel commented on patch set 1 02/18/13, 22:05

    Verified; Looks good to me, but someone else must approve
  3. Georg Ringer commented on patch set 1 V 0 02/18/13, 22:05

    by team member; Looks good to me, approved
  4. Mr. Jenkins commented on patch set 1 02/18/13, 22:05

  5. Wouter Wolters commented on patch set 1 02/18/13, 22:05

    Looks good to me, but someone else must approve
  6. Georg Ringer merged patch set 2 02/18/13, 22:05