Review main Merged Breaking

18411[!!!][FEATURE] Implement pre- and post-hook around SELECT queries

Soren Malling CR +2 V +2 Easy +37 −3 updated 06/03/13, 20:49

Commit message

To use in example content/record security,
a hook is implemented before and after the SELECT call.

The interface introduces a new function that needs to be
implemented to avoid breaking functionality!

The SELECT call is the only database call without such hook

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Mattias Nilsson +1
    • Dmitry Dulepov +1
  • Verified V +2
    • Georg Ringer +2
    • Dmitry Dulepov +1

Issues 1

Files 3

Review log 14

  1. Dmitry Dulepov commented on patch set 1 04/02/13, 06:17

    Just a note: breaks all existing hook classes.
  2. Dmitry Dulepov commented on patch set 1 04/02/13, 06:17

    It is ok for me. I just made a note. Btw, commit message misses "Releases". It is mandatory.
  3. Soren Malling commented on patch set 1 04/02/13, 06:17

    Could a "Release: 6.1" note fix that issue for you?
  4. Soren Malling uploaded patch set 2 04/02/13, 06:17

  5. Dmitry Dulepov commented on patch set 3 04/02/13, 06:17

    Looks good to me, but someone else must approve
  6. Dmitry Dulepov voted on patch set 3 V 0 04/02/13, 06:17

  7. Soren Malling uploaded patch set 3 04/02/13, 06:17

  8. Mattias Nilsson commented on patch set 3 04/02/13, 06:17

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 04/02/13, 06:17

  10. Mr. Jenkins commented on patch set 2 04/02/13, 06:17

  11. Mr. Jenkins commented on patch set 3 04/02/13, 06:17

  12. Wouter Wolters commented on patch set 3 04/02/13, 06:17

    Looks good to me, but someone else must approve
  13. Georg Ringer commented on patch set 3 V 0 04/02/13, 06:17

    by team member; Looks good to me, approved
  14. Georg Ringer merged patch set 4 04/02/13, 06:17