Review main Merged

18453[BUGFIX] Clearing cache from toolbar fails in IE8

Andreas Kießling CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

Fix for regression in #45595 that was introduced with #36364
IE8 does not pass the click event to the handler function and thus
raises a JavaScript error. The event can be fetched from the window
object in this case.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Wouter Wolters +1
    • Mattias Nilsson +1
  • Verified V +2
    • Christian Kuhn +2
    • Mario Rimann +1
    • Wouter Wolters +1
    • Mattias Nilsson +1
    • Pascal Maechler +1

Files 1

Review log 8

  1. Mario Rimann commented on patch set 1 03/07/13, 22:12

    Verified; Looks good to me, but someone else must approve Tested the patch on a 4.5.23 with IE8 -> Solved the problem.
  2. Stefan Neufeind commented on patch set 1 03/07/13, 22:12

    Looks good to me, but someone else must approve I've done it this way with older IE myself in the past. This resolution is correct to best knowledge in the context described here.
    no 4.6 anymore
  3. Mattias Nilsson commented on patch set 1 03/07/13, 22:12

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 03/07/13, 22:12

  5. Pascal Maechler commented on patch set 1 V 0 03/07/13, 22:12

    Tested in IE8. Looks fine, cache can be cleared.
  6. Wouter Wolters commented on patch set 1 03/07/13, 22:12

    Verified; Looks good to me, but someone else must approve
  7. Christian Kuhn commented on patch set 1 V 0 03/07/13, 22:12

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 03/07/13, 22:12