Review main Merged

18458[BUGFIX] Toolbar items with separator: fix white-space

Felix Kopp CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The toolbar function could output erroneous html is case
additional toolbar items do not bring additionalAttributes.

Additional attributes are defined based on ToolbarItemHookInterface.
But additionalAttributes can be an empty string:

Fix output <liclass="separator"> to <li class="separator">
by adding an extra white-space.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 4

  1. Mr. Jenkins commented on patch set 1 03/14/13, 08:57

  2. Wouter Wolters commented on patch set 1 03/14/13, 08:57

    Looks good to me, but someone else must approve
  3. Christian Kuhn commented on patch set 1 V 0 03/14/13, 08:57

    by team member; Looks good to me, approved
  4. Christian Kuhn merged patch set 2 03/14/13, 08:57