18459[FEATURE] Add stdWrap property to access values form flexforms
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 9
-
Francois Suter commented on patch set 1 05/27/13, 17:19
I took a quick look at your code, but it seems a bit too simple to me. I had implemented something similar in an extension and my code was more extensive. In particular your code always access "lDEF", seeming not to take translations into account. Could you check this: http://forge.typo3.org/projects/extension-getflexformvalue/repository/entry/trunk/class.tx_getflexformvalue_getter.php and see if it's necessary to add finer processing? -
Francois Suter commented on patch set 1 05/27/13, 17:19
This morning I remembered having set up a test file for my extension, with various scenarios. Here it is if it can help you: http://d.pr/f/Tj6E As for the syntax I prefer: 10.data = flexform:fieldname -
Soren Malling commented on patch set 1 05/27/13, 17:19
@Francois Good point with the translation! I totally forgot abou that! I will setup some different environment and see how it works out. Any comment on the syntax? 10 = TEXT 10.flexform = fieldname // I'm not satisfied about this at all! OR 10.data = flexform:fieldname -
Soren Malling commented on patch set 1 05/27/13, 17:19
I think the ".flexform" is going to be removed so you only have access with .data .flexform was a bad approach that I started with -
Soren Malling commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit this i will remove the ".flexform" approach and make sure there will be language support for the next changeset. Thanks for all your feedback! -
Jo Hasenau commented on patch set 1 05/27/13, 17:19
In this case you won't need any additional stdWrap functionality, since it is already provided by stdWrap.data So you could do: 10 = TEXT 10.data = flexform:field 10.data.override = flexform:anotherfield 10.data.override.if.isTrue.data = flexform: masterfield -
Jo Hasenau commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this You provide 'flexform' (string) and 'flexform.' (array) but only $conf['flexform'] is used in the methods. To match the behaviour of any other stdWrap method, there always should be 'flexform.' passed through stdWrap before applying the result to 'flexform'. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7556/ : SUCCESS -
Soren Malling abandoned the change 12/22/13, 01:46