18460[FEATURE] filelist: make using file_reference possible
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 14
-
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
How to test: * Use a small extension with ext_tables.php containing the following lines: t3lib_div::loadTCA('tt_content'); $GLOBALS['TCA']['tt_content']['columns']['media']['config']['internal_type'] = 'file_reference'; $GLOBALS['TCA']['tt_content']['columns']['media']['config']['uploadfolder'] = ''; * Create an element of type uploads ("File Links") and add a file from (for example) fileadmin/... to it. * Notice that files are no longer copied to uploads/media/ but instead are a reference to the file. Then check the Filelist in the frontend. File is correctly found, filesize can be displayed and just the filename without a path is shown as link-text. Since this adjustment is only necessary with custom TCA imho this is a "feature" and as such not to be backported. -
Stefan Neufeind uploaded patch set 2 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
For multiple files (of type file_reference) to show correctly the patch needed an adjustment: rescue the $path (in $basePath now) -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Fails Thanks for pointing that out. You are of course right. This was originally done against 4.5 and I just "hand-rebased" the patch to master. Didn't take FAL into account. Since it's a minor thing imho, could we get this into 4.5 and 4.7? It's just "enabling to use file_reference". If you you don't (core by default) everything is fine. -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Would appreciate some reviews on this, please. Not a big change imho. -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
But it's unfortunately not something that could be solved with just configuration. Hmm ... -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
ping! -
Christian Kuhn commented on patch set 2 05/27/13, 17:19
Fails Unable to reproduce on current master (with fal?) -
Christian Kuhn commented on patch set 2 05/27/13, 17:19
Regarding 4.7 / 4.5: Since this is a seldom case (imho) that is only raised if someone actually changes the TCA of this specific columns to file_reference (btw: is this already supported in 4.5?) and this "only" affects the file content element ... i tend to *not* fix this issue for 4.5 / 4.7 anymore. This is just not a "hard" error. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7557/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7560/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/27/13, 17:19
(1 inline comment) Will test it soonCssStyledContentController.php:320Trailing whitespace -
Wouter Wolters commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind abandoned the change 10/14/13, 12:18
Won't have / not relevant for 6.x (because of FAL). And we decided to not add this for 4.5/4.7 anymore.