Review main Abandoned

18480[BUGFIX] Flash uploader doesn't work in Filelist clickmenus

Lorenz Ulrich CR 0 V 0 Normal +58 −49 updated 06/03/13, 20:49

Commit message

The Flash uploader only works in the click menu of the folder tree in
the Filelist module. It doesn't work in
- the click menu of a folder in the "right frame"
- the click menu in a folder (in the right top)
This is because the Flash uploader JS is only observing a click event
to a button but cannot be called directly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Benni Mack commented on patch set 1 03/23/13, 11:42

    I would prefer that you didn't submit this should only go in 6.0, 4.7 and 4.5
  2. Felix Kopp commented on patch set 1 03/23/13, 11:42

    Verified; Looks good to me, but someone else must approve Very nice. That works ok. Tested in FF3.6 + FF19. Chrome25. Safari. IE9+IE10. (Further improvement could be: Reload does not have to be triggered if a file is uploaded to a sub-directory)
  3. Mr. Jenkins commented on patch set 1 03/23/13, 11:42

  4. Wouter Wolters commented on patch set 1 03/23/13, 11:42

    Please abandon this one. See for 6.0 https://review.typo3.org/#/c/19211/
  5. Wouter Wolters commented on patch set 1 03/23/13, 11:42

    Looks good to me, but someone else must approve
  6. Benni Mack commented on patch set 1 03/23/13, 11:42

    Abandoned not in 6.1, only 6.0 and below.