Review main Abandoned

18506[TASK] Migrate Web>Access table style to standard

Felix Kopp CR 0 V 0 Easy +5 −20 updated 07/27/13, 18:38

Commit message

Web>Access displays a table to edit privileges.
This tables does not adapt the standard table styles.

Adopt to standard css definitions.
Brings table row hover styles.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 10

  1. Felix Kopp commented on patch set 1 05/27/13, 17:19

    (1 inline comment)

    module_web_access.css:9

    typo3-dblist is used now. This can be removed.
  2. Felix Kopp commented on patch set 1 05/27/13, 17:19

    Please follow the discussion at http://forge.typo3.org/issues/45502.
  3. Felix Kopp commented on patch set 1 05/27/13, 17:19

    Might also be a usability bugfix for 6.0? Currently waiting for UX-team OK. Please go ahead and comment+test and review. You will find before and after screenshots on the corresponding forge ticket.
  4. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  5. Rico Sonntag commented on patch set 1 05/27/13, 17:19

    Fails To fix the missing connection of the tree-lines, due the applied padding, the sysext/t3skin/icons/gfx/ol/join.gif image should contain the padding and it should be removed from the table itself.
  6. Felix Kopp uploaded patch set 2 05/28/13, 23:12

  7. Felix Kopp uploaded patch set 3 05/28/13, 23:12

  8. Felix Kopp commented on patch set 3 05/28/13, 23:13

    I would prefer that you didn't submit this Waiting for final decision on how to display tree within table
  9. Mr. Jenkins commented on patch set 3 05/28/13, 23:13

  10. Felix Kopp abandoned the change 07/27/13, 18:38