Review main Merged

18510[TASK] Adhere enableDeprecationLog settings

Markus Klein CR +2 V +2 Easy +9 −7 updated 07/18/13, 11:44

Commit message

Refactoring of function deprecationLog() to prevent accidental
activation of log file creation due to misconfiguration.
Correct misleading configuration description (label in Install Tool).

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Alexander Opitz +1
    • Markus Klein +1
  • Verified V +2
    • Philipp Gampe +2
    • Markus Klein +1

Issues 1

Files 2

Review log 23

  1. Markus Klein uploaded patch set 2 05/27/13, 17:19

  2. Philipp Gampe commented on patch set 2 05/27/13, 17:19

    imho those lines to no hurt, I would prefer to keep them
  3. Michael Schams commented on patch set 2 05/27/13, 17:19

    Patch set 2 matches the configuration description but enables users to misconfigure the system.
  4. Markus Klein commented on patch set 3 05/27/13, 17:19

    I would prefer that you didn't submit this Submodule pointers should no be included
  5. Michael Schams uploaded patch set 3 05/27/13, 17:19

  6. Markus Klein commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve
  7. Alexander Opitz commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve
  8. Michael Schams uploaded patch set 4 05/27/13, 17:19

  9. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  11. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  12. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  13. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  14. Markus Klein uploaded patch set 5 07/16/13, 22:33

  15. Mr. Jenkins commented on patch set 5 07/16/13, 22:34

  16. Markus Klein voted on patch set 5 V +2 CR +2 07/16/13, 22:36

  17. Alexander Opitz voted on patch set 5 CR +1 07/17/13, 13:36

  18. Markus Klein uploaded patch set 6 07/17/13, 22:29

  19. Mr. Jenkins commented on patch set 6 07/17/13, 22:30

  20. Markus Klein commented on patch set 6 V +1 CR +1 07/17/13, 22:30

    Fixed the call to trimExplode() to use self:: Removed line ending problem of last change set
  21. Alexander Opitz voted on patch set 6 CR +1 07/18/13, 06:40

  22. Philipp Gampe voted on patch set 6 V +2 CR +2 07/18/13, 11:44

  23. Philipp Gampe merged patch set 7 07/18/13, 11:44