Review main Merged

18529[BUGFIX] Fix processed files if original has special chars

Tilo Baller CR +2 V +2 Easy +4 −1 updated 01/06/19, 11:15

Commit message

Filenames of files uploaded in TYPO3 CMS before 6.0.1
can contain problematic characters, because filename
sanitizing of added files was introduced with 6.0.1.

The same happens if files are not uploaded through
the TYPO3 backend and then indexed.

The filenames of processed files are sanitized when
adding them to the storage but the not sanitized
original filename identifier is kept in the database
record of the processed files, which causes wrong
generated paths.

Update the identifier of the processed file along
with all other properties after adding them
to the storage.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Issues 2

Files 1

Review log 19

  1. Helmut Hummel commented on patch set 1 04/11/13, 22:23

    I would prefer that you didn't submit this Wrong approach here. Will push another change soon
  2. Tom commented on patch set 2 04/11/13, 22:23

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 2 04/11/13, 22:23

    Verified; Looks good to me, but someone else must approve
  4. Stefan Neufeind uploaded patch set 3 04/11/13, 22:23

  5. Benni Mack commented on patch set 3 V 0 04/11/13, 22:23

    by team member; Looks good to me, approved
  6. Benni Mack merged patch set 4 04/11/13, 22:23

  7. Helmut Hummel uploaded patch set 2 04/11/13, 22:23

  8. Helmut Hummel commented on patch set 2 04/11/13, 22:23

    @Alexander: not sanitizing on filesystems that cannot handle utf8 is a no go. Sanitizing is currently done consistently in the driver. That processing files fail in the case you have not sanitized filenames in the storage must be fixed and this is the scope of this patch. Re-checking what character should be sanitized if utf-8 filesystem is enabled should be part of another patch. Maybe we could have slightly different drivers for these cases...
  9. Alexander Opitz commented on patch set 1 04/11/13, 22:23

    I would prefer that you didn't submit this Sanitizing file names is a no go.
  10. Steffen Ritter commented on patch set 2 04/11/13, 22:23

    Looks good to me, but someone else must approve please check if this is still needed...
  11. Steffen Ritter commented on patch set 2 04/11/13, 22:23

    Looks good to me, approved
  12. Christian Weiske commented on patch set 1 04/11/13, 22:23

    Fails It works for the frontend rendering, but unfortunately does not fix the issue in the file list view. Preview images there are not rendered. Please adjust your patch to also sanitize the file name in the file list preview.
  13. Mr. Jenkins commented on patch set 1 04/11/13, 22:23

  14. Mr. Jenkins commented on patch set 2 04/11/13, 22:23

  15. Mr. Jenkins commented on patch set 3 04/11/13, 22:23

  16. Tilo Baller commented on patch set 1 04/11/13, 22:23

    Please mind the notes here when reviewing this patch: http://forge.typo3.org/issues/45221#note-6
  17. Tilo Baller commented on patch set 2 04/11/13, 22:23

    Verified; Looks good to me, but someone else must approve Thanks Helmut for the better approach. Works great.
  18. Oliver Hader commented on patch set 4 04/11/13, 22:23

    This causes ProcessedFiles to be regenerated on every request. See issue #47140
  19. Henrik Ziegenhain commented on patch set 2 01/06/19, 11:15

    Looks good to me, but someone else must approve