Review main Merged

18544[BUGFIX] Extension manager styling

Felix Kopp CR +2 V +2 Normal +94 −24 updated 06/03/13, 20:49

Commit message

The extension manager never got all defined styles.
Bring several visual improvements:

— placeholder in search field
— show action icons on hover
— style extension state column
— float table header cols left and right

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jost Baron +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jost Baron +1

Files 11

Review log 27

Show 2 earlier messages
  1. Francois Suter commented on patch set 1 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve Looks good and works as expected. Two remarks/questions: - the placeholder text in the search field of the "Get extensions" tab is a nice addition, but it's a shame that both tabs are not more consistent (the "Manage extensions" tab has a label and no placeholder) - shouldn't the placeholder text disappear when the focus enters the field already, instead of waiting for the first keyup? I feel like I'm more used to the "focus" behavior.
  2. Francois Suter commented on patch set 1 04/05/13, 11:23

    BTW, Rico, we never remove labels once they are introduced, because they would also be lost in the translations, and translated packages are used by *all* versions of TYPO3.
  1. Stefan Neufeind commented on patch set 1 04/05/13, 11:23

    Looks good to me, but someone else must approve Didn't yet find the time to try it out. But makes sense by reading and looks like a nice cleanup-job. (Just note the nitpicks already mentioned.)
  2. Stefan Neufeind commented on patch set 1 04/05/13, 11:23

    Felix?
  3. Markus Klein commented on patch set 1 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve

    main.css:1658

    Indentation

    main.css:1703

    Indentation

    main.css:1705

    Indentation

    main.css:1736

    Indentation
  4. Felix Kopp commented on patch set 1 04/05/13, 11:23

    Thank you for the review, Francois. There are still few styles missing. Searchfield+Placeholder for the first tab will be included later. Also the search result view on "Get extensions". Those have separate forge issues already. I will continue the work here.

    main.css:1658 Reply

    The main.css is automatically compiled base on the scss files. I guess this has to stay this way.
  5. Felix Kopp commented on patch set 1 04/05/13, 11:23

    (1 inline comment)
  6. Felix Kopp commented on patch set 1 04/05/13, 11:23

    Hi Rico, would you mind removing your negative vote based on the new information? Thank you very much. You can alo contact me directly to speak about the issues. Thanks
  7. Felix Kopp commented on patch set 1 04/05/13, 11:23

    The patch realizes the definition by user experience team. Please see linked ticket on Forge system for further information. This wil be implemented for further lists as well. Please see http://forge.typo3.org/issues/39921 and also http://forge.typo3.org/issues/43932 Also we never drop labels.
  8. Mattias Nilsson commented on patch set 1 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 04/05/13, 11:23

  10. Wouter Wolters commented on patch set 1 04/05/13, 11:23

    In Internet Explorer there are several small issues, see Forge for screenshots.
  11. Wouter Wolters commented on patch set 1 04/05/13, 11:23

    Fails IE is not 100%, Felix got the details from me and can ask me for assistence.
  12. Marcus Schwemer commented on patch set 2 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve
  13. Markus Klein commented on patch set 2 04/05/13, 11:23

    Looks good to me, but someone else must approve
  14. Christian Kuhn commented on patch set 3 V 0 04/05/13, 11:23

    by team member; Looks good to me, approved
  15. Felix Kopp uploaded patch set 3 04/05/13, 11:23

  16. Felix Kopp commented on patch set 3 04/05/13, 11:23

    Improved contrast for inactive / uninstalled extensions in list. Changed CSS value.
  17. Anja Leichsenring commented on patch set 2 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve
  18. Anja Leichsenring commented on patch set 3 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 2 04/05/13, 11:23

  20. Mr. Jenkins commented on patch set 3 04/05/13, 11:23

  21. Jost Baron commented on patch set 2 04/05/13, 11:23

    This is basically a rebase to current master, merging Ter.html. It does not fix the IE gradient issues. These problems seem to lay a bit deeper (simply adding a "filter"-CSS rule does not help), and should probably handled in a new patch. They are already present in current master, so this patch does not introduce them.
  22. Jost Baron uploaded patch set 2 04/05/13, 11:23

  23. Jost Baron commented on patch set 3 04/05/13, 11:23

    Verified; Looks good to me, but someone else must approve
  24. Rico Sonntag commented on patch set 1 04/05/13, 11:23

    Fails * If you drop labels like "searchTemplate.yourSearch" you should also remove them from locallang.xlf. * I think the possible actions should always be visible to the user not just on hover.
  25. Christian Kuhn merged patch set 4 04/05/13, 11:23