Review main Merged

18555[TASK] Deprecated Big/Small/Medium/Standard-Document

Felix Kopp CR +2 V +2 Normal +46 −70 updated 06/03/13, 20:49

Commit message

Deprecates classes:

- BigDocumentTemplate
- SmallDocumentTemplate
- MediumDocumentTemplate
- StandardDocumentTemplate

These classes are rarely used.
Also the standard style in the backend move along.

Review

  • Code review CR +2
    • Benni Mack +2
    • Magdalena Leichsenring +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Magdalena Leichsenring +1
    • Anja Leichsenring +1

Issues 1

Files 27

Show 7 more files

Review log 20

  1. Philipp Gampe commented on patch set 1 04/05/13, 15:27

    Looks good, but I think we should keep the CSS styles until we really remove the classes.
  2. Felix Kopp commented on patch set 1 04/05/13, 15:27

    Thank you for the review. I had to think about your valid argument concerning the removal of the CSS definitions. I still think the CSS should be removed. Because there won't be a way to get the corresponding div-container at first. All Template objects that were to set the div-class are now setting the "normal" fall back css class - which is empty by default (DocumentTemplate::divClass = ''). External extensions could add one of CSS classes right from within the template. These extensions will have (only) too small margins in backend modules. But: extensions with backend module that are to be compatible with 6.1 should be tested and adapted correspondingly. Let us please remove the CSS as well.
  3. Mr. Jenkins commented on patch set 1 04/05/13, 15:27

  4. Wouter Wolters commented on patch set 1 04/05/13, 15:27

    Looks good to me, but someone else must approve
  5. Philipp Gampe commented on patch set 2 04/05/13, 15:27

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 2 04/05/13, 15:27

    No score If you can assure that all extension will work like before, then we can remove the CSS.
  7. Dmitry Dulepov commented on patch set 3 04/05/13, 15:27

    They are used a lot in extensions though.
  8. Stefan Neufeind commented on patch set 3 04/05/13, 15:27

    Looks good to me, but someone else must approve To what I saw the change looks okay and not too complicated, though quite a lot of places are touched.
  9. Benni Mack uploaded patch set 4 04/05/13, 15:27

  10. Benni Mack commented on patch set 4 V 0 04/05/13, 15:27

    by team member; Looks good to me, approved
  11. Felix Kopp uploaded patch set 3 04/05/13, 15:27

  12. Felix Kopp commented on patch set 3 04/05/13, 15:27

    Do not erase CSS classes
  13. Anja Leichsenring commented on patch set 4 04/05/13, 15:27

    Verified; Looks good to me, but someone else must approve
  14. Mr. Jenkins commented on patch set 2 04/05/13, 15:27

  15. Mr. Jenkins commented on patch set 3 04/05/13, 15:27

  16. Mr. Jenkins commented on patch set 4 04/05/13, 15:27

  17. Wouter Wolters uploaded patch set 2 04/05/13, 15:27

  18. Wouter Wolters commented on patch set 2 04/05/13, 15:27

    Verified; Looks good to me, but someone else must approve The following submodules needs to be adapted after merge: version ./typo3/sysext/version/Classes/Controller/VersionModuleController.php ./typo3/sysext/version/Classes/Controller/WorkspaceModuleController.php dbal ./typo3/sysext/dbal/Classes/Controller/ModuleController.php
  19. Magdalena Leichsenring commented on patch set 4 04/05/13, 15:27

    Verified; Looks good to me, but someone else must approve
  20. Benni Mack merged patch set 5 04/05/13, 15:27