18555[TASK] Deprecated Big/Small/Medium/Standard-Document
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Magdalena Leichsenring +1
- Anja Leichsenring +1
-
Verified V +2
- Benni Mack +2
- Magdalena Leichsenring +1
- Anja Leichsenring +1
Issues 1
Files 27
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/FileUploadController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/RenameFileController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/FormsController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+1 −1
- typo3/sysext/backend/Classes/Controller/BackendLayoutWizardController.php+2 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NoDocumentsOpenController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Classes/Template/MediumDocumentTemplate.php+6 −5
- typo3/sysext/backend/Classes/Template/SmallDocumentTemplate.php+6 −5
- typo3/sysext/backend/Classes/Template/StandardDocumentTemplate.php+6 −5
- typo3/sysext/backend/Classes/Wizard/TsconfigWizard.php+1 −1
- typo3/sysext/cms/layout/res/grideditor.css+1 −28
Show 7 more files
- typo3/sysext/form/Classes/View/Wizard/WizardView.php+1 −1
- typo3/sysext/func/Classes/Controller/PageFunctionsController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/ModuleController.php+1 −1
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+2 −2
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+1 −1
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
Review log 20
-
Philipp Gampe commented on patch set 1 04/05/13, 15:27
Looks good, but I think we should keep the CSS styles until we really remove the classes. -
Felix Kopp commented on patch set 1 04/05/13, 15:27
Thank you for the review. I had to think about your valid argument concerning the removal of the CSS definitions. I still think the CSS should be removed. Because there won't be a way to get the corresponding div-container at first. All Template objects that were to set the div-class are now setting the "normal" fall back css class - which is empty by default (DocumentTemplate::divClass = ''). External extensions could add one of CSS classes right from within the template. These extensions will have (only) too small margins in backend modules. But: extensions with backend module that are to be compatible with 6.1 should be tested and adapted correspondingly. Let us please remove the CSS as well. -
Mr. Jenkins commented on patch set 1 04/05/13, 15:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7606/ : SUCCESS -
Wouter Wolters commented on patch set 1 04/05/13, 15:27
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 04/05/13, 15:27
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 04/05/13, 15:27
No score If you can assure that all extension will work like before, then we can remove the CSS. -
Dmitry Dulepov commented on patch set 3 04/05/13, 15:27
They are used a lot in extensions though. -
Stefan Neufeind commented on patch set 3 04/05/13, 15:27
Looks good to me, but someone else must approve To what I saw the change looks okay and not too complicated, though quite a lot of places are touched. -
Benni Mack uploaded patch set 4 04/05/13, 15:27
-
Benni Mack commented on patch set 4 V 0 04/05/13, 15:27
by team member; Looks good to me, approved -
Felix Kopp uploaded patch set 3 04/05/13, 15:27
-
Felix Kopp commented on patch set 3 04/05/13, 15:27
Do not erase CSS classes -
Anja Leichsenring commented on patch set 4 04/05/13, 15:27
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 04/05/13, 15:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7664/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/05/13, 15:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7776/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/05/13, 15:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8158/ : SUCCESS -
Wouter Wolters uploaded patch set 2 04/05/13, 15:27
-
Wouter Wolters commented on patch set 2 04/05/13, 15:27
Verified; Looks good to me, but someone else must approve The following submodules needs to be adapted after merge: version ./typo3/sysext/version/Classes/Controller/VersionModuleController.php ./typo3/sysext/version/Classes/Controller/WorkspaceModuleController.php dbal ./typo3/sysext/dbal/Classes/Controller/ModuleController.php -
Magdalena Leichsenring commented on patch set 4 04/05/13, 15:27
Verified; Looks good to me, but someone else must approve -
Benni Mack merged patch set 5 04/05/13, 15:27