Review TYPO3_6-0 Merged

18577[BUGFIX] PHP filesystem functions are locale dependent

Steffen Ritter CR +2 V +2 Normal +110 −20 updated 06/03/13, 20:49

Commit message

PHP filesystem functions like pathinfo, dirname and
basename are dependent on the locale set in PHP.
If one enables UTF8filesystem in the install tool, he may
use non-ascii characters in filenames and directory names.
For this to work properly you need to configure
SystemLocale, too.

The file abstraction layer classes need to take care of
the SystemLocale; to avoid code duplication new static
wrapper functions have been introduced.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 10

Review log 4

  1. Oliver Hader uploaded patch set 2 04/01/13, 13:03

  2. Steffen Ritter commented on patch set 1 04/01/13, 13:03

    reminder
  3. Oliver Hader commented on patch set 2 V 0 04/01/13, 13:03

    by team member; Looks good to me, approved Backport from master, extended for ImageProcessingService which has been removed in master, but is still there in 6.0
  4. Oliver Hader merged patch set 3 04/01/13, 13:03