18687[TASK] Make the update-from-TER link more visible
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Philipp Gampe +1
Issues 1
Files 8
- typo3/sysext/extensionmanager/Classes/ViewHelpers/UpdateFromTerViewHelper.phpdeleted+0 −62
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/UpdateFromTer.htmlnew+16 −0
- typo3/sysext/extensionmanager/Resources/Private/Scss/page/_manage.scss+4 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/UpdateFromTer/UpdateExtensionListFromTer.json+2 −2
- typo3/sysext/extensionmanager/Resources/Public/Css/main.css+3 −0
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/update.js+19 −7
Review log 17
-
Philipp Gampe commented on patch set 1 03/11/13, 20:30
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 1 03/11/13, 20:30
Please have a look at: http://forge.typo3.org/attachments/21908/new_em_03.png within: http://forge.typo3.org/issues/39921 A button is planned. And that should be integrated. Could you implement the layout attached to the ticket above? -
Felix Kopp commented on patch set 1 03/11/13, 20:30
Yes, well hidden in several discussions. Thank you a lot! I will review of course -
Mattias Nilsson commented on patch set 1 03/11/13, 20:30
Verified; Looks good to me, but someone else must approve Nice work a real improvement! -
Mr. Jenkins commented on patch set 1 03/11/13, 20:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7622/ : SUCCESS -
Jost Baron commented on patch set 1 03/11/13, 20:30
Yes, I'll do that (sometime tomorrow probably). Didn't know there are screens for that. -
Christian Kuhn commented on patch set 2 03/11/13, 20:30
Verified; Looks good to me, but someone else must approve Very good. Thanks a lot for this one! Looks fine for me and works. -
Christian Kuhn commented on patch set 2 V 0 03/11/13, 20:30
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 03/11/13, 20:30
-
Philipp Gampe commented on patch set 2 03/11/13, 20:30
Verified; Looks good to me, but someone else must approve There is a bug in Chrome that does not remove the loading mask after extension list update - no JS error; but this happens without the patch too. Maybe some JS wizard can have a look? -
Philipp Gampe commented on patch set 2 03/11/13, 20:30
Yes, this helped. I also reviewed the other patch now :) -
Anja Leichsenring commented on patch set 2 03/11/13, 20:30
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 03/11/13, 20:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7646/ : SUCCESS -
Jost Baron commented on patch set 2 03/11/13, 20:30
@Felix: The change is half in there. The time of the last update could be displayed nicer, but that would probably blow this change to much. -
Jost Baron commented on patch set 2 03/11/13, 20:30
Hi Philipp, maybe this patch helps when identifying that bug? https://review.typo3.org/#/c/18688/ -
Jost Baron uploaded patch set 2 03/11/13, 20:30
-
Christian Kuhn commented on patch set 3 03/11/13, 20:30
ah, and i think we should have this one in 6.0, too.