Review main Merged

18687[TASK] Make the update-from-TER link more visible

Jost Baron CR +2 V +2 Normal +54 −72 updated 06/03/13, 20:49

Commit message

Make the "update from TER"-action in the extension manager more
visible by showing a button for it, instead of a text link.

Also moved the rendering functionality of the update link from
a viewhelper to a partial, as partials tend to be more readable
and bug free.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Philipp Gampe +1

Issues 1

Files 8

Review log 17

  1. Philipp Gampe commented on patch set 1 03/11/13, 20:30

    Verified; Looks good to me, but someone else must approve
  2. Felix Kopp commented on patch set 1 03/11/13, 20:30

    Please have a look at: http://forge.typo3.org/attachments/21908/new_em_03.png within: http://forge.typo3.org/issues/39921 A button is planned. And that should be integrated. Could you implement the layout attached to the ticket above?
  3. Felix Kopp commented on patch set 1 03/11/13, 20:30

    Yes, well hidden in several discussions. Thank you a lot! I will review of course
  4. Mattias Nilsson commented on patch set 1 03/11/13, 20:30

    Verified; Looks good to me, but someone else must approve Nice work a real improvement!
  5. Mr. Jenkins commented on patch set 1 03/11/13, 20:30

  6. Jost Baron commented on patch set 1 03/11/13, 20:30

    Yes, I'll do that (sometime tomorrow probably). Didn't know there are screens for that.
  7. Christian Kuhn commented on patch set 2 03/11/13, 20:30

    Verified; Looks good to me, but someone else must approve Very good. Thanks a lot for this one! Looks fine for me and works.
  8. Christian Kuhn commented on patch set 2 V 0 03/11/13, 20:30

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 3 03/11/13, 20:30

  10. Philipp Gampe commented on patch set 2 03/11/13, 20:30

    Verified; Looks good to me, but someone else must approve There is a bug in Chrome that does not remove the loading mask after extension list update - no JS error; but this happens without the patch too. Maybe some JS wizard can have a look?
  11. Philipp Gampe commented on patch set 2 03/11/13, 20:30

    Yes, this helped. I also reviewed the other patch now :)
  12. Anja Leichsenring commented on patch set 2 03/11/13, 20:30

    Verified; Looks good to me, but someone else must approve
  13. Mr. Jenkins commented on patch set 2 03/11/13, 20:30

  14. Jost Baron commented on patch set 2 03/11/13, 20:30

    @Felix: The change is half in there. The time of the last update could be displayed nicer, but that would probably blow this change to much.
  15. Jost Baron commented on patch set 2 03/11/13, 20:30

    Hi Philipp, maybe this patch helps when identifying that bug? https://review.typo3.org/#/c/18688/
  16. Jost Baron uploaded patch set 2 03/11/13, 20:30

  17. Christian Kuhn commented on patch set 3 03/11/13, 20:30

    ah, and i think we should have this one in 6.0, too.