Review main Merged

18688[TASK] Show better error messages on failed TER update

Jost Baron CR +2 V +2 Easy +23 −10 updated 06/03/13, 20:49

Commit message

This patch shows error messages in a flash message if the ajax request
for a TER-update fails, and resets the extension manager into a sane
state, instead of showing an ever spinning wheel.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 11

  1. Mr. Jenkins commented on patch set 1 03/11/13, 20:58

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7623/ : FAILURE
  2. Wouter Wolters commented on patch set 1 03/11/13, 20:58

    He Jost, Thanks for the patch. Jenkins complains about the commit message. See https://ci.typo3.org/job/typo3-v4-core-gerrit/7623/console
  3. Alexander Opitz commented on patch set 2 03/11/13, 20:58

    Looks good to me, but someone else must approve
  4. Philipp Gampe commented on patch set 2 03/11/13, 20:58

    Verified; Looks good to me, but someone else must approve Nice patch :)
  5. Mr. Jenkins commented on patch set 2 03/11/13, 20:58

  6. Mr. Jenkins commented on patch set 3 03/11/13, 20:58

  7. Wouter Wolters uploaded patch set 3 03/11/13, 20:58

  8. Wouter Wolters commented on patch set 3 03/11/13, 20:58

    Verified; Looks good to me, but someone else must approve
  9. Jost Baron uploaded patch set 2 03/11/13, 20:58

  10. Christian Kuhn commented on patch set 3 V 0 03/11/13, 20:58

    by team member; Looks good to me, approved Great. Now we can debug why this fails sometimes. Very good!
  11. Christian Kuhn merged patch set 4 03/11/13, 20:58