Review main Merged

18689[BUGFIX] Get suggest wizard working with renderMode=checkbox

Markus Klein CR +2 V +2 Easy +38 −5 updated 01/23/14, 22:42

Commit message

In case a select field with renderMode "checkbox" is used together with
the suggest wizard, clicking the suggestions will not check the
related item in the list and therefore the wizard isn't useful anyhow
in that combination.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Files 3

Review log 22

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve Briefly browsed the code and saw where the new parameters are handed through etc.
  2. Mattias Nilsson commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  4. Wouter Wolters uploaded patch set 2 05/28/13, 19:58

  5. Mr. Jenkins commented on patch set 2 05/28/13, 19:59

  6. Markus Klein uploaded patch set 3 09/18/13, 10:31

  7. Mr. Jenkins commented on patch set 3 09/18/13, 10:32

  8. Markus Klein uploaded patch set 4 12/02/13, 11:54

  9. Mr. Jenkins commented on patch set 4 12/02/13, 12:27

  10. Markus Klein commented on patch set 4 12/12/13, 01:50

    @Steffen R: Can this go into 4.7?
  11. Helmut Hummel commented on patch set 4 12/12/13, 16:05

    to me this sounds more like a feature so I'd say leave it out at least for 6.0 (can't speak for other branches but tend to only include this in 6.2)
  12. Stefan Neufeind commented on patch set 4 12/12/13, 17:37

    from forge-description: "Also the pending documentation claims that the new suggest wizard is working nicely with group and select fields, it's not the case for select fields for two reasons" [...] So I tend to see this as a "fix". But I personally didn't have the usecase for it yet, so I'm fine if it's at least fixed in 6.2. Imho still a fix.
  13. Oliver Hader updated the commit message in patch set 4 12/16/13, 16:29

  14. Oliver Hader commented on patch set 5 12/16/13, 16:32

    We discussed the back-port of this issue to TYPO3 4.x branches and agreed on not back-porting it. The change is however valid for 6.2 and 6.1 as the current stable and released branch
  15. Mr. Jenkins commented on patch set 5 12/16/13, 16:41

  16. Markus Klein voted on patch set 5 CR +1 12/16/13, 19:23

  17. Markus Klein rebased onto patch set 5 01/23/14, 19:56

  18. Markus Klein voted on patch set 6 CR +1 01/23/14, 19:57

  19. Mr. Jenkins commented on patch set 6 01/23/14, 20:19

  20. Markus Klein commented on patch set 6 V +1 01/23/14, 20:41

    For testing instructions please see forge.
  21. Wouter Wolters voted on patch set 6 V +2 CR +2 01/23/14, 22:42

  22. Wouter Wolters merged patch set 7 01/23/14, 22:42