Review main Merged

18690[BUGFIX] Get folder object if a path is given

Ivan Dharma Kartolo CR +2 V +2 Easy +45 −4 updated 06/03/13, 20:49

Commit message

Get folder instead file object if a path is given to FAL.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Alexander Opitz +1
  • Verified V +2
    • Anja Leichsenring +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Alexander Opitz +1

Issues 1

Files 2

Review log 36

Show 11 earlier messages
  1. Philipp Gampe commented on patch set 1 04/06/13, 12:42

    (2 inline comments) Will push an update for the commit message. Could you write a unit test for this. There are already some and it should be possible to extend one a bit.
    also 6.1
    no empty line here, please update your git commit hook (see wiki)
  2. Andreas Wolf commented on patch set 2 04/06/13, 12:42

    I would prefer that you didn't submit this This potentially breaks stuff, as Benni said. We should instead check the type of the item at the given path, or return an error when the file method is used for a folder or vice versa.
  3. Stefan Neufeind commented on patch set 2 04/06/13, 12:42

    Looks good to me, but someone else must approve no-brainer
  4. Benni Mack commented on patch set 2 04/06/13, 12:42

    @Ivan: What happens if you have a full filename like "typo3temp/myfile.jpg" - then the tool fails. so we need to check if it is a file or folder.
  5. Benni Mack uploaded patch set 3 04/06/13, 12:42

  6. Benni Mack uploaded patch set 4 04/06/13, 12:42

  7. Stefan Neufeind commented on patch set 5 04/06/13, 12:42

    Looks good to me, but someone else must approve
  8. Benni Mack uploaded patch set 5 04/06/13, 12:42

  9. Alexander Opitz commented on patch set 2 04/06/13, 12:42

    Looks good to me, but someone else must approve
  10. Steffen Ritter commented on patch set 2 04/06/13, 12:42

    I opt for: allow only files here... you only would need a folder in storage null if you wanna put sth. there... This we don't want to allow, only files which are there need to be accessed should work via fallback.
  11. Steffen Ritter commented on patch set 2 04/06/13, 12:42

    Do not submit
  1. Steffen Ritter commented on patch set 5 04/06/13, 12:42

    Verified; Looks good to me, approved
  2. Steffen Ritter commented on patch set 5 04/06/13, 12:42

    Looks good to me, but someone else must approve
  3. Ivan Dharma Kartolo commented on patch set 2 04/06/13, 12:42

    @Benni: then the method retrieveFileOrFolderObject misses an "if" (or "else") to check if it's a file of a folder? ;)
  4. Philipp Gampe commented on patch set 2 04/06/13, 12:42

    Did you test with something like chgallery which does use folders? AFAIK you could always link folders too
  5. Philipp Gampe uploaded patch set 2 04/06/13, 12:42

  6. Anja Leichsenring uploaded patch set 6 04/06/13, 12:42

  7. Anja Leichsenring commented on patch set 6 04/06/13, 12:42

    Verified; Looks good to me, but someone else must approve added an unit test.
  8. Stefan Neufeind commented on patch set 7 04/06/13, 12:42

    Verified; Looks good to me, but someone else must approve
  9. Alexander Opitz commented on patch set 7 04/06/13, 12:42

    Verified; Looks good to me, but someone else must approve
  10. Anja Leichsenring uploaded patch set 7 04/06/13, 12:42

  11. Stefan Neufeind commented on patch set 8 04/06/13, 12:42

    Verified; Looks good to me, but someone else must approve just reapplying
  12. Alexander Opitz commented on patch set 8 04/06/13, 12:42

    Verified; Looks good to me, but someone else must approve
  13. Steffen Ritter commented on patch set 8 V 0 04/06/13, 12:42

    by team member; Looks good to me, approved
  14. Anja Leichsenring uploaded patch set 8 04/06/13, 12:42

  15. Anja Leichsenring commented on patch set 8 04/06/13, 12:42

    Verified; Looks good to me, but someone else must approve improved unit tests a little bit.
  16. Mr. Jenkins commented on patch set 1 04/06/13, 12:42

  17. Mr. Jenkins commented on patch set 2 04/06/13, 12:42

  18. Mr. Jenkins commented on patch set 3 04/06/13, 12:42

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8189/ : FAILURE
  19. Mr. Jenkins commented on patch set 4 04/06/13, 12:42

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8191/ : FAILURE
  20. Mr. Jenkins commented on patch set 5 04/06/13, 12:42

  21. Mr. Jenkins commented on patch set 6 04/06/13, 12:42

  22. Mr. Jenkins commented on patch set 7 04/06/13, 12:42

  23. Mr. Jenkins commented on patch set 8 04/06/13, 12:42

  24. Anja Leichsenring commented on patch set 8 V 0 04/06/13, 12:42

    by team member; Looks good to me, approved
  25. Anja Leichsenring merged patch set 9 04/06/13, 12:42