Review main Merged

18757[BUGFIX] ExtensionManagementUtility tries to include non-existing files

Dmitry Dulepov CR +2 V +2 Normal +82 −44 updated 06/03/13, 20:49

Commit message

Methods createExtLocalconfCacheEntry() and createExtTablesCacheEntry()
attempt to include files without checking if they exist. This causes
PHP warnings about non-existing files and looses time in a call to
GeneralUtility::getUrl().

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 12

  1. Dmitry Dulepov uploaded patch set 2 03/07/13, 20:47

  2. Dmitry Dulepov commented on patch set 2 03/07/13, 20:47

    (1 inline comment)
  3. Markus Klein commented on patch set 2 03/07/13, 20:47

    (1 inline comment)

    ExtensionManagementUtility.php:1573

    What about inverting the condition and using a continue?

    ExtensionManagementUtility.php:1573 Reply

    Alright. I'm fine with your opinion. I consider continue not as bad as goto, but I'm just wondering about the single return for functions, because we have load of them having a guard with an early return, which of course make a lot of sense IMO.
  4. Markus Klein commented on patch set 2 1 comment 03/07/13, 20:47

    Looks good to me, but someone else must approve
  5. Christian Kuhn commented on patch set 2 03/07/13, 20:47

    True. Looks straight an fine on first glance already. Have them on my radar and will take care after regression fix release.
  6. Christian Kuhn uploaded patch set 3 03/07/13, 20:47

  7. Mr. Jenkins commented on patch set 1 03/07/13, 20:47

  8. Mr. Jenkins commented on patch set 2 03/07/13, 20:47

  9. Mr. Jenkins commented on patch set 3 03/07/13, 20:47

  10. Wouter Wolters commented on patch set 2 03/07/13, 20:47

    Looks good to me, but someone else must approve Thanks for this patch Dmitry. Indeed both functions are assuming that every extension has both files. The checks are similar to the one at line 1735.
  11. Christian Kuhn commented on patch set 3 V 0 03/07/13, 20:47

    by team member; Looks good to me, approved Good catch. The new patch set doesn't change the code in question but adds two unit tests. They fail if the 'if ext_tables' is commented and are fine with the full patch. Since I wrote the code in question and we already had two positives votes, I'll now merge this patch together with the tests. The code change itself is straight and obvious anyway. Thanks.
  12. Christian Kuhn merged patch set 4 03/07/13, 20:47