18757[BUGFIX] ExtensionManagementUtility tries to include non-existing files
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 2
Review log 12
-
Dmitry Dulepov uploaded patch set 2 03/07/13, 20:47
-
Dmitry Dulepov commented on patch set 2 03/07/13, 20:47
(1 inline comment) -
Markus Klein commented on patch set 2 03/07/13, 20:47
(1 inline comment)ExtensionManagementUtility.php:1573What about inverting the condition and using a continue?ExtensionManagementUtility.php:1573ReplyAlright. I'm fine with your opinion. I consider continue not as bad as goto, but I'm just wondering about the single return for functions, because we have load of them having a guard with an early return, which of course make a lot of sense IMO. -
Markus Klein commented on patch set 2 1 comment 03/07/13, 20:47
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 03/07/13, 20:47
True. Looks straight an fine on first glance already. Have them on my radar and will take care after regression fix release. -
Christian Kuhn uploaded patch set 3 03/07/13, 20:47
-
Mr. Jenkins commented on patch set 1 03/07/13, 20:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7639/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/07/13, 20:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7640/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/07/13, 20:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7652/ : SUCCESS -
Wouter Wolters commented on patch set 2 03/07/13, 20:47
Looks good to me, but someone else must approve Thanks for this patch Dmitry. Indeed both functions are assuming that every extension has both files. The checks are similar to the one at line 1735. -
Christian Kuhn commented on patch set 3 V 0 03/07/13, 20:47
by team member; Looks good to me, approved Good catch. The new patch set doesn't change the code in question but adds two unit tests. They fail if the 'if ext_tables' is commented and are fine with the full patch. Since I wrote the code in question and we already had two positives votes, I'll now merge this patch together with the tests. The code change itself is straight and obvious anyway. Thanks. -
Christian Kuhn merged patch set 4 03/07/13, 20:47