18760[BUGFIX] ExtDirectApi uses an undefined variable
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 10
-
Dmitry Dulepov commented on patch set 1 03/20/13, 20:24
In the Recycler ext (to go Web>Recycler). You need php error reporting or some other log monitoring tool to see the error. Example: http://forge.typo3.org/attachments/23554/sentry-report.png -
Dmitry Dulepov commented on patch set 1 03/20/13, 20:24
Oops, sorry, recycler was about another error. Basically, I got it with Sentry, which shows me all kind of errors and warnings. -
Dmitry Dulepov commented on patch set 1 03/20/13, 20:24
I work too much today :( Yes, it was recycler. -
Stefan Neufeind commented on patch set 1 03/20/13, 20:24
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 03/20/13, 20:24
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/20/13, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7641/ : SUCCESS -
Wouter Wolters voted on patch set 1 V 0 03/20/13, 20:24
-
Wouter Wolters commented on patch set 1 03/20/13, 20:24
Looks good to me, but someone else must approve Dmitry, can you give an example where this is happening so I can verify the patch? -
Christian Kuhn commented on patch set 1 V 0 03/20/13, 20:24
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 03/20/13, 20:24