Review main Merged

18760[BUGFIX] ExtDirectApi uses an undefined variable

Dmitry Dulepov CR +2 V +2 Easy +14 −14 updated 06/03/13, 20:49

Commit message

Method generateAPI() sets $className inside the condition but later uses
it without checking if it is empty or not. The result is a PHP warning
"Invalid argument supplied for foreach()".

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 10

  1. Dmitry Dulepov commented on patch set 1 03/20/13, 20:24

    In the Recycler ext (to go Web>Recycler). You need php error reporting or some other log monitoring tool to see the error. Example: http://forge.typo3.org/attachments/23554/sentry-report.png
  2. Dmitry Dulepov commented on patch set 1 03/20/13, 20:24

    Oops, sorry, recycler was about another error. Basically, I got it with Sentry, which shows me all kind of errors and warnings.
  3. Dmitry Dulepov commented on patch set 1 03/20/13, 20:24

    I work too much today :( Yes, it was recycler.
  4. Stefan Neufeind commented on patch set 1 03/20/13, 20:24

    Looks good to me, but someone else must approve
  5. Christian Kuhn commented on patch set 1 03/20/13, 20:24

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 03/20/13, 20:24

  7. Wouter Wolters voted on patch set 1 V 0 03/20/13, 20:24

  8. Wouter Wolters commented on patch set 1 03/20/13, 20:24

    Looks good to me, but someone else must approve Dmitry, can you give an example where this is happening so I can verify the patch?
  9. Christian Kuhn commented on patch set 1 V 0 03/20/13, 20:24

    by team member; Looks good to me, approved
  10. Christian Kuhn merged patch set 2 03/20/13, 20:24