Review main Merged

18762[BUGFIX] BELog module error: "vsprintf(): Too few arguments"

Dmitry Dulepov CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

AbstractExceptionHandler contains a function named writeLog. That
function adds an entry to the system log. System log expects not
just a string but a string format with % characters. Callers of
this methods may supply a URL ("Request URL:" in the log message)
that contains % characters. vsprintf() in the BELog view helper
will complain about missing arguments to such string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Christian Kuhn commented on patch set 1 03/19/13, 19:57

    sounds logical and i've seen such errors as well ... will test and give it a real review soon.
  2. Christian Kuhn commented on patch set 1 03/19/13, 19:57

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 03/19/13, 19:57

  4. Wouter Wolters commented on patch set 1 03/19/13, 19:57

    No score
  5. Wouter Wolters voted on patch set 1 V 0 03/19/13, 19:57

  6. Christian Kuhn commented on patch set 1 V 0 03/19/13, 19:57

    by team member; Looks good to me, approved
  7. Christian Kuhn merged patch set 2 03/19/13, 19:57