Review main Merged

18780[FEATURE] Option to disable exports (csv / t3d) in dblist

Kai Richter CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

This patch adds an TSConfig option to disable csv and t3d (impexp)
export in single table view in list module. This option is for
example important to disable batch download of sensitive data via
csv or t3d exports.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 12

  1. Christian Kuhn uploaded patch set 3 03/25/13, 19:58

  2. Christian Kuhn commented on patch set 3 03/25/13, 19:58

    Verified; Looks good to me, but someone else must approve Fix the if, so the exports links are show again if noExportRecordsLinks = 0 is set.
  3. Christian Kuhn uploaded patch set 4 03/25/13, 19:58

  4. Kai Richter uploaded patch set 2 03/25/13, 19:58

  5. Anja Leichsenring commented on patch set 3 03/25/13, 19:58

    Verified; Looks good to me, but someone else must approve
  6. Anja Leichsenring commented on patch set 4 03/25/13, 19:58

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 03/25/13, 19:58

  8. Mr. Jenkins commented on patch set 2 03/25/13, 19:58

  9. Mr. Jenkins commented on patch set 3 03/25/13, 19:58

  10. Mr. Jenkins commented on patch set 4 03/25/13, 19:58

  11. Christian Kuhn commented on patch set 4 V 0 03/25/13, 19:58

    by team member; Looks good to me, approved +1 for the feature. be aware: This is no security feature! By constructing the according link, creating and d/l of csv is still possible ... just the buttons are not shown anymore. Merged. Documentation issue will be created by me now.
  12. Christian Kuhn merged patch set 5 03/25/13, 19:58