Review TYPO3_4-5 Merged

18798[BUGFIX] Clearing cache from toolbar fails in IE8

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

Fix for regression in #45595 that was introduced with #36364
IE8 does not pass the click event to the handler function and thus
raises a JavaScript error. The event can be fetched from the window
object in this case.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Files 1

Review log 4

  1. Christian Kuhn commented on patch set 1 03/07/13, 22:20

    Please confirm this patch works with IE6 before merge.
  2. Wouter Wolters commented on patch set 1 03/07/13, 22:20

    Verified; Looks good to me, but someone else must approve This one is extra verified by me in IE6
  3. Christian Kuhn commented on patch set 1 V 0 03/07/13, 22:20

    by team member; Looks good to me, approved
  4. Christian Kuhn merged patch set 2 03/07/13, 22:20