18805[BUGFIX] Importing extensions from repository fails
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Files 3
Review log 21
-
Mr. Jenkins commented on patch set 1 03/17/13, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7656/ : SUCCESS -
Christian Kuhn commented on patch set 2 03/17/13, 10:17
I would prefer that you didn't submit this -1 for now: The code is not clean. Furtermore, I'd suggest to add tests to this model method to show with the unit tests what this method returns under which circumstances.Extension.php:242catIndex is not used afterwards. -
Christian Kuhn commented on patch set 2 03/17/13, 10:17
other than that, i've also seen db errors fetching the ext-list, but i didn't investigate the reason, yet. so, we should get a fix in quickly. if nobody takes a deeper look at the code and tests, i'll probably do it tomorrow or friday evening. -
Christian Futterlieb commented on patch set 2 V 0 03/17/13, 10:17
@Wouter Wolters: Thanks for pushing the patch ;) -
Christian Futterlieb commented on patch set 2 03/17/13, 10:17
No score @Christian Kuhn: Thanks for taking care of this problem. You are right, the code was not good ($catIndex not returned), I fixed that. @all: sorry, it seems that I messed up with pushing patch set 3.. It's now here: https://review.typo3.org/#/c/18891/ -
Mr. Jenkins commented on patch set 2 03/17/13, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7657/ : SUCCESS -
Wouter Wolters uploaded patch set 2 03/17/13, 10:17
-
Christian Kuhn commented on patch set 3 03/17/13, 10:17
working on this now. -
Christian Kuhn uploaded patch set 4 03/17/13, 10:17
-
Christian Kuhn uploaded patch set 5 03/17/13, 10:17
-
Christian Kuhn uploaded patch set 6 03/17/13, 10:17
-
Christian Kuhn uploaded patch set 7 03/17/13, 10:17
-
Christian Kuhn commented on patch set 7 V 0 03/17/13, 10:17
by team member; Looks good to me, approved i'm sure this works now. merged. -
Christian Kuhn merged patch set 8 03/17/13, 10:17
-
Christian Futterlieb voted on patch set 3 V 0 03/17/13, 10:17
-
Mr. Jenkins commented on patch set 3 03/17/13, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7741/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/17/13, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7754/ : SUCCESS -
Mr. Jenkins commented on patch set 6 03/17/13, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7756/ : SUCCESS -
Mr. Jenkins commented on patch set 7 03/17/13, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7757/ : SUCCESS -
Wouter Wolters uploaded patch set 3 03/17/13, 10:17
-
Christian Futterlieb commented on patch set 8 03/17/13, 10:17
@Christian Kuhn: much better like that, thank you for your work!